WHAT

Update the kafka storage expansion scripts to use max_data_retention_size instead of kafka_storage_size field in the request payload to PATCH /admin/kafkas/

WHY

The kafka_storage_size field in the following endpoints have now been deprecated (see MGDSTRM-8442)

• GET /admin/kafkas
• GET /admin/kafkas/{id}
• PATCH /admin/kafkas/{id}

HOW

Update the following places to use max_data_retention_size instead of kafka_storage_size:

• patch_kafkas()
• kafka-storage-expansions README
• Validate section of the following SOPs:
  • kafka/manual_storage_expansion
  • alerts/manual_storage_expansion

Verification

Create kafka (either in stage or prod (or both if desired). Add kafka(s) ID and updated max_data_retention_size to configurations/<env>. Save the config, obtain the secret values for relevant environment(s) from here and run from the root of kafka-storage-expansions repo:

CLIENT_ID=<secret> CLIENT_SECRET=<secret> STAGE_CLIENT_ID=<secret> STAGE_CLIENT_SECRET=<secret> ./run.sh

DONE

• kafka_storage_size replaced by max_data_retention_size in the kafka-storage-expansion repository and SOPs

Guidelines

The following steps should be adhered to:

• Required tests should be put in place - unit, integration, manual test cases (if necessary)
• CI and all relevant tests passing
• Changes have been verified by one additional reviewer against:
• each required environment
• each supported upgrade path
• If the changes could have an impact on the clients (either UI or CLI), a JIRA should be created for making the required changes on the client side and acknowledged by one of the client side team members. PR has been merged