-
Task
-
Resolution: Done
-
Minor
-
None
-
None
-
None
-
3
-
True
-
-
False
-
Yes
-
---
-
---
-
MK - Sprint 228
WHAT
kafka_storage_size has been deprecated in the following schemas in MGDSTRM-8442 :
- KafkaRequest (public api):
- GET /kafkas
- POST /kafkas
- GET /kafkas/{id}
- PATCH /kafkas/{id}
- Kafka (private admin api)
- GET /admin/kafkas
- GET /admin/kafkas/{id}
- DELETE /admin/kafkas/{id}
- KafkaUpdateRequest (private admin api)
- PATCH /admin/kafkas/{id}
WHY
Deprecated field kafka_storage_size should be removed after the deprecation period has passed and clients are no longer using it.
HOW
- Remove kafka_storage_size from the public and private admin api openapi spec.
Needs to be removed from:
- https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/blob/main/openapi/kas-fleet-manager.yaml#L990
- https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/blob/main/openapi/kas-fleet-manager-private-admin.yaml#L252
- https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/blob/main/openapi/kas-fleet-manager-private-admin.yaml#L308
- Ensure to run make openapi/generate
- Update any tests affected by this change.
DONE
- The KAS Fleet Manager public and private API should no longer support kafka_storage_size
Guidelines
The following steps should be adhered to:
- Required tests should be put in place - unit, integration, manual test cases (if necessary)
- CI and all relevant tests passing
- Changes have been verified by one additional reviewer against:
- each required environment
- each supported upgrade path
- If the changes could have an impact on the clients (either UI or CLI), a JIRA should be created for making the required changes on the client side and acknowledged by one of the client side team members. PR has been merged
- is blocked by
-
MGDSTRM-8982 Use max_data_retention_size on kafka storage expansion
- Closed
- relates to
-
MGDSTRM-8442 Inconsistent format returned for quantity limits in KafkaRequest and SupportedKafkaInstanceSize schemas
- Closed