-
Task
-
Resolution: Done
-
Major
-
None
-
None
rcernich1 suggested we merge the ServiceMeshMember and ServiceMeshMemberRoll controllers into a single controller. But this would make the single controller responsible for too many things and it would be difficult to reason about its operation. Instead, let's redesign these two controllers.
The ServiceMeshMemberRoll controller should no longer be responsible for configuring member namespaces. Instead, it should only create ServiceMeshMember objects in those namespaces that are added to SMMR.spec.members. The ServiceMeshMember controller should be responsible for configuring each namespace that contains the ServiceMeshMember object, regardless of who creates this object (it can be created by users directly or by the SMMR controller via the SMMR).
This should simplify the whole system and separate the list of namespaces that the mesh admin adds to the mesh from the individual namespaces that are added to the mesh by mesh users via the ServiceMeshMember resource.
The SMMR.spec.members field will contain only the namespaces that the mesh admin adds, whereas the namespaces with a manually created ServiceMeshMember object, will only appear in SMMR.status.members (and SMMR.status.configuredMembers).
- incorporates
-
MAISTRA-1350 Users should not be able to create SMM in projects that are already listed in SMMR
-
- Closed
-