Uploaded image for project: 'Kogito'
  1. Kogito
  2. KOGITO-8683

SWF Viewer - Orthogonal lines improvements

XMLWordPrintable

    • False
    • None
    • False
    • ---
    • ---

      The following bugs were introduced by KOGITO-8445 feature. See pullrequestreview-1300028088.

      Issues

      The graph is not centered when there are more levels with more states.

      The outgoing connection to the node that is in the same or higher level is pinned to the bottom magnet instead of west/east magnet.

      • The actual behaviour conforms with the jira description, but it would make much more sense to use east/west magnets.
      • See monitor-job.sw.json from specification
      • To be partially fixed by KOGITO-8716, see also KOGITO-8755

      If the connection is going from source to target directly to level above, it is going from west magnet. It might look better if it went directly from the top magnet.

      The connections are going through states.

      The backward connection are going through states.

      The connection crosses other connections

      The connections are going through states/nodes in some scenarios if there are multiple states/nodes in the same level, depending on node distribution.
      There is also an issue with connections when the states don't have incoming connections, so the nodes are shown next to the Start node. As a result, the connections are going through the same level states.

      Acceptance criteria

      All issues mentioned above are fixed.

        1. book-lending.sw.json
          3 kB
          Lubomir Terifaj
        2. car-vitals-checks-parent.sw.json
          1.0 kB
          Lubomir Terifaj
        3. connections-through-same-level-nodes.png
          17 kB
          Lubomir Terifaj
        4. connection-through-state.png
          12 kB
          Lubomir Terifaj
        5. continuing-as-a-new-execution.sw.json
          1 kB
          Lubomir Terifaj
        6. filling-a-glass-of-water.sw.json
          0.9 kB
          Lubomir Terifaj
        7. hello-world-more-states.sw.json
          2 kB
          Lubomir Terifaj
        8. monitor-job.sw.json
          3 kB
          Lubomir Terifaj
        9. not-centered-diagram.png
          12 kB
          Lubomir Terifaj
        10. pinned-bottom-magnet.png
          7 kB
          Lubomir Terifaj
        11. pinned-west-magnet.png
          13 kB
          Lubomir Terifaj

              handreyrc Handrey Cunha
              lterifaj@redhat.com Lubomir Terifaj
              Daniel Rosa Daniel Rosa
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: