Uploaded image for project: 'Kogito'
  1. Kogito
  2. KOGITO-4654

Kogito-Tooling code formatting

    XMLWordPrintable

Details

    • 2021 Week 13-15 (from Mar 29), 2021 Week 16-18 (from Apr 19)

    Description

      FAI-362 pull request (PR) demonstrates consequence of kogito-tooling non unified formatting. Then appears pull requests containing more formatting changes than logical changes.

      We should investigate option of unify formatting and then require formatting been applied as part of full downstream build.

      We already have this requirement for [kogito-apps/ui-packages/https://github.com/kiegroup/kogito-apps/blob/master/ui-packages/]. It is defined in '.prettierrc' file. Most of options are set to default values. However those not set to default are:

      • "singleQuote": true
      • "trailingComma": "none"

      Both options above should be considered also for kogito-tooling. Complete list of options can be seen here. After my investigation of changes done by prettier: these options should be discussed:

      • "singleQuote"
      • "trailingComa"
      • "arrowParens"
      • "tabWidth"

      Acceptance criteria

      • check of formatting is automatically done with every PR
      • README informs of needed setup for developers, actions needed before opening PR
      • changes announced via an e-mail

      Attachments

        Issue Links

          Activity

            People

              rh-ee-jomarko Jozef Marko
              rh-ee-jomarko Jozef Marko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: