Our package structure is a mess, especially internal ones are wrong.

Ex. org.jboss.tools.openshift ui:
There are 2 internal packages:

• org.jboss.tools.openshift.internal.ui
• org.jboss.tools.openshift.ui.internal
  

Internal packages have to follow the base component name, which in our case is org.jboss.tools.openshift:

• org.jboss.tools.openshift.internal.ui: CORRECT
• org.jboss.tools.openshift.ui.internal: WRONG

For the background:

• https://wiki.eclipse.org/Naming_Conventions#Internal_Implementation_Packages:

  All implementation packages should be flagged as internal, with the tag occurring just after the major package name

• http://wiki.eclipse.org/Naming_Conventions#Java_Packages

  org.eclipse.jdt.internal.core.compiler - Correct usage
  org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow project name.
  org.eclipse.core.internal.resources - Correct usage
  org.eclipse.internal.core.resources - Incorrect. internal should never immediately follow org.eclipse.
  org.eclipse.core.resources.internal - Incorrect. internal should immediately follow Eclipse Platform component name.