Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-26164

internal packages are a mess

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Done
    • Minor
    • 4.9.0.AM2
    • 4.6.0.AM3
    • openshift

    Description

      Our package structure is a mess, especially internal ones are wrong.

      Ex. org.jboss.tools.openshift ui:
      There are 2 internal packages:

      • org.jboss.tools.openshift.internal.ui
      • org.jboss.tools.openshift.ui.internal

      Internal packages have to follow the base component name, which in our case is org.jboss.tools.openshift:

      • org.jboss.tools.openshift.internal.ui: CORRECT
      • org.jboss.tools.openshift.ui.internal: WRONG

      For the background:

      • https://wiki.eclipse.org/Naming_Conventions#Internal_Implementation_Packages:

        All implementation packages should be flagged as internal, with the tag occurring just after the major package name

      • http://wiki.eclipse.org/Naming_Conventions#Java_Packages

        org.eclipse.jdt.internal.core.compiler - Correct usage
        org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow project name.
        org.eclipse.core.internal.resources - Correct usage
        org.eclipse.internal.core.resources - Incorrect. internal should never immediately follow org.eclipse.
        org.eclipse.core.resources.internal - Incorrect. internal should immediately follow Eclipse Platform component name.

      Attachments

        Issue Links

          Activity

            People

              adietish@redhat.com André Dietisheim
              adietish@redhat.com André Dietisheim
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: