Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-6595

(7.0.z) JBJCA-1325 - Wrong condition when parsing ironjacamar.rollback_on_fatal_error property

    Details

    • Type: Bug
    • Status: Verified (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 7.0.4.CR1, 7.0.4.GA
    • Component/s: None
    • Labels:
      None

      Description

      There is wrong condition in https://github.com/ironjacamar/ironjacamar/blob/1.3/core/src/main/java/org/jboss/jca/core/connectionmanager/listener/TxConnectionListener.java#L180

            value = SecurityActions.getSystemProperty("ironjacamar.rollback_on_fatal_error");
            if (value != null && !value.trim().equals(""))
            {
               if ("true".equalsIgnoreCase(value) || "false".equalsIgnoreCase(value))
               {
                  doSetRollbackOnly = Boolean.parseBoolean(value);
               }
               else
               {
                  StringTokenizer st = new StringTokenizer(value, ",");
                  while (doDelistResource && st.hasMoreTokens()) // <-- should be while (doSetRollbackOnly ...
                  {
                     if (getPool().getName().equals(st.nextToken()))
                        doSetRollbackOnly = false;
                  }
               }
            }
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  baranowb Bartosz Baranowski
                  Reporter:
                  bmaxwell Brad Maxwell
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: