Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-5453

Wrong condition when parsing ironjacamar.rollback_on_fatal_error property

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 7.1.0.DR9
    • 7.1.0.DR1
    • JCA
    • None

    Description

      There is wrong condition in https://github.com/ironjacamar/ironjacamar/blob/1.3/core/src/main/java/org/jboss/jca/core/connectionmanager/listener/TxConnectionListener.java#L180

            value = SecurityActions.getSystemProperty("ironjacamar.rollback_on_fatal_error");
            if (value != null && !value.trim().equals(""))
            {
               if ("true".equalsIgnoreCase(value) || "false".equalsIgnoreCase(value))
               {
                  doSetRollbackOnly = Boolean.parseBoolean(value);
               }
               else
               {
                  StringTokenizer st = new StringTokenizer(value, ",");
                  while (doDelistResource && st.hasMoreTokens()) // <-- should be while (doSetRollbackOnly ...
                  {
                     if (getPool().getName().equals(st.nextToken()))
                        doSetRollbackOnly = false;
                  }
               }
            }
      

      Attachments

        Issue Links

          Activity

            People

              istudens@redhat.com Ivo Studensky
              msimka@redhat.com Martin Simka
              Martin Simka Martin Simka
              Martin Simka Martin Simka
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: