Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-11408

Elytron revise why exception stacktrace is not logged in some cases

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Critical
    • 7.1.0.ER2
    • 7.1.0.DR19
    • Security
    • None

    Description

      During verification of JBEAP-9297 I have found another occurences where logging should be justified.
      In some cases not logging exception can hide original cause of problem.

      But justification is necessary if extending loggin won't introduce unnecessary logs, however does not seems to me this should be case.

      [mchoma@localhost wildfly-elytron]$ grep -r ".*\.debug([^\"]" --include=*.java .
      ./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                ElytronMessages.log.debug(e);
      ./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                            ElytronMessages.log.debug(e);
      ./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                ElytronMessages.log.debug(e);
      ./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                                    ElytronMessages.log.debug(e);
      ./src/main/java/org/wildfly/security/http/util/SecurityProviderServerMechanismFactory.java:                            log.debug(e);
      ./src/main/java/org/wildfly/security/http/util/SecurityProviderServerMechanismFactory.java:                            log.debug(e);
      ./src/main/java/org/wildfly/security/http/util/ServiceLoaderServerMechanismFactory.java:                log.debug(e);
      ./src/main/java/org/wildfly/security/http/util/ServiceLoaderServerMechanismFactory.java:                log.debug(e);
      ./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslClientFactory.java:                            log.debug(e);
      ./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslClientFactory.java:                            log.debug(e);
      ./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslServerFactory.java:                                log.debug(e);
      ./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslServerFactory.java:                            log.debug(e);
      
      [mchoma@localhost wildfly-elytron]$ grep -r ".*\.trace([^\"]" --include=*.java .
      ./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:            ElytronMessages.tls.trace(b);
      ./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:                    ElytronMessages.tls.trace(b);
      ./src/main/java/org/wildfly/security/http/impl/DigestAuthenticationMechanism.java:                        log.trace(e);
      

      These are OK

      ./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:            ElytronMessages.tls.trace(b);
      ./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:                    ElytronMessages.tls.trace(b);
      

      Setting to Critical priority, as this could reveal useful information during process of troubleshooting.

      Attachments

        Issue Links

          Activity

            People

              rhn-engineering-lgao Lin Gao
              mchoma@redhat.com Martin Choma
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 2 days
                  2d
                  Remaining:
                  Remaining Estimate - 2 days
                  2d
                  Logged:
                  Time Spent - Not Specified
                  Not Specified