Uploaded image for project: 'WildFly Elytron'
  1. WildFly Elytron
  2. ELY-1233

Elytron revise why exception stacktrace is not logged in some cases

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • 1.1.0.Beta54
    • None
    • None
    • None

      During verification of JBEAP-9297 I have found another occurences where logging should be justified.
      In some cases not logging exception can hide original cause of problem.

      But justification is necessary if extending loggin won't introduce unnecessary logs, but it does not seems to me this should be case.

      [mchoma@localhost wildfly-elytron]$ grep -r ".*\.debug([^\"]" --include=*.java .
./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                ElytronMessages.log.debug(e);
./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                            ElytronMessages.log.debug(e);
./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                ElytronMessages.log.debug(e);
./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                                    ElytronMessages.log.debug(e);
./src/main/java/org/wildfly/security/http/util/SecurityProviderServerMechanismFactory.java:                            log.debug(e);
./src/main/java/org/wildfly/security/http/util/SecurityProviderServerMechanismFactory.java:                            log.debug(e);
./src/main/java/org/wildfly/security/http/util/ServiceLoaderServerMechanismFactory.java:                log.debug(e);
./src/main/java/org/wildfly/security/http/util/ServiceLoaderServerMechanismFactory.java:                log.debug(e);
./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslClientFactory.java:                            log.debug(e);
./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslClientFactory.java:                            log.debug(e);
./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslServerFactory.java:                                log.debug(e);
./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslServerFactory.java:                            log.debug(e);

[mchoma@localhost wildfly-elytron]$ grep -r ".*\.trace([^\"]" --include=*.java .
./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:            ElytronMessages.tls.trace(b);
./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:                    ElytronMessages.tls.trace(b);
./src/main/java/org/wildfly/security/http/impl/DigestAuthenticationMechanism.java:                        log.trace(e);

      These are OK

      ./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:            ElytronMessages.tls.trace(b);
./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:                    ElytronMessages.tls.trace(b);

      Setting to Critical priority, as this could reveal useful information during process of troubleshooting.

              rhn-engineering-lgao Lin Gao
              mchoma@redhat.com Martin Choma
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: