Uploaded image for project: 'OpenShift Image Registry'
  1. OpenShift Image Registry
  2. IR-261

As an OpenShift user I want to create an image using oc tag --import-mode=...

XMLWordPrintable

    • BU Product Work
    • False
    • None
    • False
    • Sprint 230

      ACCEPTANCE CRITERIA

      • The cmd line flag should result in the ImageStreamImport and ImageStream objects specifying the API manifest list flag

      DOCUMENTATION

      • The new flag should be mentioned in the product documentation.

      OPEN QUESTIONS

          1.
          		 QE Tracker - IR-261 Sub-task Closed Undefined Wen Wang

            [IR-261] As an OpenShift user I want to create an image using oc tag --import-mode=...

            Wen Wang added a comment -

            dwerle Tested the pr, according test case, no issue found.

            Wen Wang added a comment - dwerle Tested the pr, according test case, no issue found.

            Dylan Orzel added a comment -

            dwerle Yes, I've left the validation to the API. It seems to behave nicely. If the --import-mode is left blank, it takes the default 'Legacy', and if --import-mode is anything but 'PreserveOriginal', it errors and gives a list of valid values. 

            Dylan Orzel added a comment - dwerle Yes, I've left the validation to the API. It seems to behave nicely. If the --import-mode is left blank, it takes the default 'Legacy', and if --import-mode is anything but 'PreserveOriginal', it errors and gives a list of valid values. 

            Dominik Werle added a comment -

            dorzel: regarding the open question (or rather its answer): if implemented as in your draft, and which I copied to the IR-261 draft PR, I would just leave the validation to the API server to reject/accept, that is also what you plan on doing, right?

            Apart from that, I tried the new flag as suggested in my PR and it seems to result in the state we want. However, I have to think a bit about a (tag_test.go) test that makes sense to supply for the change.

            Dominik Werle added a comment - dorzel : regarding the open question (or rather its answer): if implemented as in your draft, and which I copied to the IR-261 draft PR , I would just leave the validation to the API server to reject/accept, that is also what you plan on doing, right? Apart from that, I tried the new flag as suggested in my PR and it seems to result in the state we want. However, I have to think a bit about a (tag_test.go) test that makes sense to supply for the change.

              dwerle Dominik Werle
              fmissi Flavian Missi
              Wen Wang Wen Wang
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: