• Type: Task
• Resolution: Done
• Priority: Major
• Fix Version/s: hms-1.3
• Affects Version/s: None
• Component/s: Image Builder, Provisioning
• Labels:

  None

1. 

   Screenshot 2023-09-07 at 12.53.06.png

   172 kB

   2023/09/07 11:01 AM

2. 

   Screenshot 2023-09-07 at 12.53.13.png

   145 kB

   2023/09/07 11:01 AM

[HMS-2352] Add an option in IB wizard not to share the image with an account (GCP)

Collapse comment: Thomas Lavocat added a comment - 2023/09/27 7:27 AM

Thomas Lavocat added a comment - 2023/09/27 7:27 AM

The backend for IB got changed on this PR https://github.com/osbuild/image-builder/pull/840. I will now support having an empty `option` object for the upload request.
The PR https://github.com/RedHatInsights/image-builder-frontend/pull/1355 needs to get updated to no longer be sending:
{"distribution":"rhel-92","image_name":"adi","image_requests":[{"architecture":"x86_64","image_type":"gcp","upload_request":{"type":"gcp","options":

{"share_with_accounts":["user:undefined"]}

}}],"customizations":{}}
but instead:
{"distribution":"rhel-92","image_name":"adi","image_requests":[\{"architecture":"x86_64","image_type":"gcp","upload_request":{"type":"gcp","options":{}}}],"customizations":{}}
 

Expand comment: Thomas Lavocat added a comment - 2023/09/27 7:27 AM

Thomas Lavocat added a comment - 2023/09/27 7:27 AM The backend for IB got changed on this PR https://github.com/osbuild/image-builder/pull/840. I will now support having an empty `option` object for the upload request. The PR https://github.com/RedHatInsights/image-builder-frontend/pull/1355 needs to get updated to no longer be sending: {"distribution":"rhel-92","image_name":"adi","image_requests":[{"architecture":"x86_64","image_type":"gcp","upload_request":{"type":"gcp","options": {"share_with_accounts":["user:undefined"]} }}],"customizations":{}} but instead: {"distribution":"rhel-92","image_name":"adi","image_requests": [\{"architecture":"x86_64","image_type":"gcp","upload_request":{"type":"gcp","options":{}}}] ,"customizations":{}}  

Collapse comment: Ondrej Ezr added a comment - 2023/09/08 10:12 AM

Ondrej Ezr added a comment - 2023/09/08 10:12 AM

Thanks msviriko1! <3

Expand comment: Ondrej Ezr added a comment - 2023/09/08 10:12 AM

Ondrej Ezr added a comment - 2023/09/08 10:12 AM Thanks msviriko1 ! <3

Collapse comment: Mária Šviriková added a comment - 2023/09/07 11:03 AM

Mária Šviriková added a comment - 2023/09/07 11:03 AM

Mocks here, reviewed by the doc team.

Expand comment: Mária Šviriková added a comment - 2023/09/07 11:03 AM

Mária Šviriková added a comment - 2023/09/07 11:03 AM Mocks here, reviewed by the doc team.

Collapse comment: Adi Abramovich (Inactive) added a comment - 2023/08/27 11:44 AM

Adi Abramovich (Inactive) added a comment - 2023/08/27 11:44 AM

Blocked until we get mocks from UX and having a discussion with Tiho.

Expand comment: Adi Abramovich (Inactive) added a comment - 2023/08/27 11:44 AM

Adi Abramovich (Inactive) added a comment - 2023/08/27 11:44 AM Blocked until we get mocks from UX and having a discussion with Tiho.

Collapse comment: RHEL Jira bot added a comment - 2023/08/21 2:04 PM

RHEL Jira bot added a comment - 2023/08/21 2:04 PM

The Fix Version/s on this issue have been changed by automation.

Expand comment: RHEL Jira bot added a comment - 2023/08/21 2:04 PM

RHEL Jira bot added a comment - 2023/08/21 2:04 PM The Fix Version/s on this issue have been changed by automation.