Uploaded image for project: 'Hybrid Application Console'
  1. Hybrid Application Console
  2. HAC-765

Fix `Store` usages in SDK

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • None
    • Core

      The `Store` from redux is a problem for typing. There is a confusion around what exactly is in the `Store` – since we have two states, it could be the App's state + some additional stuff we apply OR it could flat out be just our state (if the App does not do a provider above us).

      Acceptance Criteria

      • Search for `Store` in the lib-utils package
        • `Store` is an invalid definition and should be using generics
        • `Store` with an unknown type is invalid, as we know it's at least our store data

      We need to be explicit whenever possible in the SDK repo. Generics are the easiest approach to this problem as we KNOW our store is at least our reducers/state. `State extends SDKStoreState` is a min requirement in all cases when talking about Redux Store.

            spadgett@redhat.com Samuel Padgett
            aballantyne Andrew Ballantyne
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: