Uploaded image for project: 'Hybrid Application Console'
  1. Hybrid Application Console
  2. HAC-396

Adjust SDK Reducer Rename BACK to K8s (from sdkK8s)

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

      It would seem the code in OpenShift Console is not cleanly setup and we cannot trust TypeScript / UI tests to save us from refactor breaks. There is at least one instance of the k8s reducer being addressed via a string. This brings me to the concern of causing issues with the 4.10 OCP release.

      Acceptance Criteria

      • Once HAC-374 merges we should have all k8s information under the SDK umbrella
      • Cleanup the `sdkK8s` redux reducer/state to be `k8s` so that it has less of an impact on the OCP release

      History Behind The Change

      • In HAC-198 we added `sdkK8s` to the redux state
      • In PR 10513 (Comment) it was requested that we have unique names for the SDK to allow for SDK to live next to the app's reducers but it has had side-effects
      • We are looking at closing up the SDK's data at some point (HAC-395) so give a more curated flow and less tying app operations with internals / SDK structure
      • When we originally did the `k8s` => `sdkK8s`, we broke a magic string usage: PR 10681 (be sure we convert it back)

            bflorkie@redhat.com Bryan Florkiewicz
            aballantyne Andrew Ballantyne
            Archiver:
            rhn-support-sthamilt Stacey Hamilton

              Created:
              Updated:
              Resolved:
              Archived: