Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-4519

Modify the default scraping of Argo CD metrics to optional

XMLWordPrintable

    • 8
    • False
    • None
    • False
    • Hide
      This enhancement makes the automatic scraping of metrics optional in the GitOps operator. Before this update, the user had no way to opt out of scraping of metrics, now the user can configure the ArgoCD instance to disable/enable metrics collection for their instance.
      The can edit the CR to disable metrics on their instance,

      apiVersion: argoproj.io/v1beta1
      kind: ArgoCD
      metadata:
       name: argocd-sample
       namespace: default
      spec:
       monitoring:
         disableMetrics: true

      Or using CLI
      oc patch argocd argocd-sample -n default --type='json' -p='[{"op": "replace", "path": "/spec/monitoring/disableMetrics", "value": true}]'

      Note - By default, the scraping of metrics is enabled for all ArgoCD instances.
      Show
      This enhancement makes the automatic scraping of metrics optional in the GitOps operator. Before this update, the user had no way to opt out of scraping of metrics, now the user can configure the ArgoCD instance to disable/enable metrics collection for their instance. The can edit the CR to disable metrics on their instance, apiVersion: argoproj.io/v1beta1 kind: ArgoCD metadata:  name: argocd-sample  namespace: default spec:  monitoring:    disableMetrics: true Or using CLI oc patch argocd argocd-sample -n default --type='json' -p='[{"op": "replace", "path": "/spec/monitoring/disableMetrics", "value": true}]' Note - By default, the scraping of metrics is enabled for all ArgoCD instances.
    • GitOps Crimson - Sprint 3256, GitOps Crimson - Sprint 3257

      Story (Required)

      The Operator sets up each ArgoCD instance to be scraped by OpenShift cluster monitoring (by creating ServiceMonitors and labeling the namespace with openshift.io/cluster-monitoring=true), without the possibility to opt-out.

      We need to make this optional on a per-instance basis.

      Background (Required)

      For customers with a lot of ArgoCD instances, the scraped metrics result in a huge amount of storage being used, and it provides very little to no value to them.

      See https://issues.redhat.com/browse/RFE-3120 for more details.

      Out of scope

      <Defines what is not included in this story>

      Approach (Required)

      <Description of the general technical path on how to achieve the goal of the story. Include details like json schema, class definitions>

      Dependencies

      <Describes what this story depends on. Dependent Stories and EPICs should be linked to the story.>

      Acceptance Criteria (Mandatory)

      • Each ArgoCD instance can opt-out of automated scraping
      • CI - MUST be running successfully with tests automated
      • Release Technical Enablement - Provide necessary release enablement details and documents.
      • Make sure the changes are backward compatible and does not any existing customers.

      INVEST Checklist

      Dependencies identified

      Blockers noted and expected delivery timelines set

      Design is implementable

      Acceptance criteria agreed upon

      Story estimated

      Legend

      Unknown

      Verified

      Unsatisfied

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

              saumeyakatyal Saumeya Katyal (Inactive)
              aveerama@redhat.com Abhishek Veeramalla
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: