Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-3006

Make automatic scraping of Argo CD metrics optional

XMLWordPrintable

    • Make automatic scraping of Argo CD metrics optional
    • False
    • None
    • False
    • RFE-3120Possible turning of the openshift.io/cluster-monitoring label
    • To Do
    • 0% To Do, 0% In Progress, 100% Done
    • Hide

      This enhancement makes the automatic scraping of metrics optional in the GitOps operator. Before this update, the user had no way to opt out of scraping of metrics, now the user can configure the ArgoCD instance to disable/enable metrics collection for their instance.
      The can edit the CR to disable metrics on their instance,

      apiVersion: argoproj.io/v1beta1
      kind: ArgoCD
      metadata:
       name: argocd-sample
       namespace: default
      spec:
       monitoring:
         disableMetrics: true

      Or using CLI
      oc patch argocd argocd-sample -n default --type='json' -p='[{"op": "replace", "path": "/spec/monitoring/disableMetrics", "value": true}]'

      Note - By default, the scraping of metrics is enabled for all ArgoCD instances.
      Show
      This enhancement makes the automatic scraping of metrics optional in the GitOps operator. Before this update, the user had no way to opt out of scraping of metrics, now the user can configure the ArgoCD instance to disable/enable metrics collection for their instance. The can edit the CR to disable metrics on their instance, apiVersion: argoproj.io/v1beta1 kind: ArgoCD metadata:  name: argocd-sample  namespace: default spec:  monitoring:    disableMetrics: true Or using CLI oc patch argocd argocd-sample -n default --type='json' -p='[{"op": "replace", "path": "/spec/monitoring/disableMetrics", "value": true}]' Note - By default, the scraping of metrics is enabled for all ArgoCD instances.
    • Enhancement

      Epic Goal

      The Operator sets up each ArgoCD instance to be scraped by OpenShift cluster monitoring (by creating ServiceMonitors and labeling the namespace with openshift.io/cluster-monitoring=true), without the possibility to opt-out.

      We need to make this optional on a per-instance basis.

      Why is this important?

      For customers with a lot of ArgoCD instances, the scraped metrics result in a huge amount of storage being used, and it provides very little to no value to them.

      See https://issues.redhat.com/browse/RFE-3120 for more details.

      Scenarios

      1. ...

      Acceptance Criteria (Mandatory)

      • Each ArgoCD instance can opt-out of automated scraping
      • CI - MUST be running successfully with tests automated
      • Release Technical Enablement - Provide necessary release enablement details and documents.
      • Make sure the changes are backward compatible and does not any existing customers.

      Dependencies (internal and external)

      1. ...

      Previous Work (Optional):

      1. …

      Open questions::

      1. …
      •  

      Done Checklist

      • Acceptance criteria are met
      • Non-functional properties of the Feature have been validated (such as performance, resource, UX, security or privacy aspects)
      • User Journey automation is delivered
      • Support and SRE teams are provided with enough skills to support the feature in production environment

              saumeyakatyal Saumeya Katyal
              jfischer@redhat.com Jann Fischer
              Votes:
              3 Vote for this issue
              Watchers:
              12 Start watching this issue

                Created:
                Updated:
                Resolved: