Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-2647

Update the Controller to work off the new Application CR field rather than annotation

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Won't Do
    • Icon: Major Major
    • None
    • None
    • ArgoCD
    • None
    • GITOPS Sprint 232, GITOPS Sprint 235, GITOPS Sprint 236, GITOPS Sprint 239, GITOPS Sprint 3251

      Story (Required)

      As a Developer trying to enable image updater in Argo CD I want to be able to store image update configuration in first-class CR fields rather than using annotations

      Background (Required)

      Image Updater currently works on a set of complicated annotations that have a lot of room for misconfiguration. Part of the reason to merge image updater into Argo CD is to allow image update configuration to be done via dedicated fields in the application CR. This brings type validation and easy of use among many other things. The image updater's code base will need to be updated to recognize these new fields in the spec and status of the application and stop reacting to existing annotations. It should be able to perform pesudo-persistent write back through "argocd" write back method

      Out of scope

      git write back

      Approach (Required)

      Update controller logic to check for specific application fields in stead of presence of annotations, and perform "argocd" write back method. Previous implementation PR (https://github.com/argoproj/argo-cd/pull/10446) can be used for reference  

      Dependencies

      Updated Application API

      Acceptance Criteria (Mandatory)

      <Describe edge cases to consider when implementing the story and defining tests>

      <Provides a required and minimum list of acceptance tests for this story. More is expected as the engineer implements this story>

      • Able to set up the image updater using the new filed in Application CRD
      • Will not have annotation in the new implementation
      • Application rollbacks are honored
      • unit/e2e tests

      INVEST Checklist

      Dependencies identified

      Blockers noted and expected delivery timelines set

      Design is implementable

      Acceptance criteria agreed upon

      Story estimated

      Legend

      Unknown

      Verified

      Unsatisfied

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

              jrao@redhat.com Jaideep Rao
              wtam_at_redhat William Tam
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: