Uploaded image for project: 'Fast Datapath Product'
  1. Fast Datapath Product
  2. FDP-1602

Update code review script to move issues back to "In Progress"

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • OVN
    • None
    • 5
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide

      Given a Jira issue linked to a Patchwork review,

      When the Patchwork event is patch-state-changed to any state not in (New, Under Review, Accepted),

      Then the integration sets the Jira issue to “In Progress”.

      When a new version is posted or state returns to (New, Under Review),

      Then the issue is set to “In Review” and all transitions are logged. 

      Show
      Given a Jira issue linked to a Patchwork review, When the Patchwork event is patch-state-changed to any state not in (New, Under Review, Accepted), Then the integration sets the Jira issue to “In Progress”. When a new version is posted or state returns to (New, Under Review), Then the issue is set to “In Review” and all transitions are logged. 
    • rhel-9
    • None
    • rhel-net-ovn
    • ssg_networking

      We have a script that runs every hour and checks Patchwork for new patches in the OVN project. If a Jira issue is cited in any new patches, then the script sends a POST to a Jira webhook with the review URL. Jira automation then sets the issue to the "In Review" state and adds a comment to the issue with the review URL.

      We want to update the behavior so that once a review has had comments made on it, and changes have been requested, then the review is moved back to "In Progress" while the developer makes the requested changes. Once a new version of the review is posted, then the issue can be set to "In Review" again.

      To make these changes, we will need to do the following:
      1. The script currently only sends the review URL to the Jira webhook. The script will need to now also send the recommended state to change the issue to. The current script should indicate the state change to be "In Review".
      2. The Jira automation will need to be updated to transition the issue to the state given in the webhook data.
      3. The script currently only checks for the "patch-created" event to find patches in the "new" state. The script will also need to check for the "patch-state-changed" event now. If the patch changes state to anything other than "new", "under review", or "accepted", then the script should tell the webhook to transition back to "In Progress".

              ovnteam@redhat.com OVN Team
              mmichelson Mark Michelson
              Jianlin Shi Jianlin Shi
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: