Uploaded image for project: 'Debezium'
  1. Debezium
  2. DBZ-6366

Code Improvements for skip.messages.without.change

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Minor Minor
    • 2.3.0.CR1
    • 2.2.0.Final
    • postgresql-connector
    • None
    • False
    • False
    • Undefined

      Refactor code as per review comments on PR#4378 

      • CommonConnectorConfig will get passed to AbstractChangeRecordEmitter
      • RelationalDatabaseConnectorConfig will get passed to RelationalDatabaseChangeRecordEmitter
      • skipMessagesWithoutChange method could be pulled up to AbstractChangeRecordEmitter
      • connectorConfig.skipMessagesWithoutChange() will not be passed to change record emitters

      As a result

      • The only changes to record emitters (unfortunately now to all) will be passing the connector config to the parent class
      • It will enable seamless improvements for future changes/configs that will be common for all emitters
      • The feature can be enabled for MongoDB and other connectors as well

              Unassigned Unassigned
              ironakj Ronak Jain (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: