On Mon, Sep 9, 2024 at 4:04 AM Miro Hrončok <mhroncok@redhat.com> wrote:
>
> Hello.
>
> I have a c10s PR here:
>
> https://gitlab.com/redhat/centos-stream/rpms/pyproject-rpm-macros/-/merge_requests/21
>
> The rhel-10.0-beta branch already exists, this is targeted to GA.
>
> The MR contains a merge commit from Fedora, so some commits naturally don't
> have any Jira tickets in them. I know about it and I want it that way.
>
>
> ```
> I expected the pipeline to warn, but it fails:
>
> Checking commits for approved ticket references
> Branch rhel-10.0-beta exists in RHEL dist-git. Using rules from c10s
> ...
> *** Checking commit c8abf80acd2192342ed1f14e867523a24f761797
> *** No approved issue IDs referenced in log message or changelog
> *** No issue IDs referenced in log message or changelog
> *** Make sure to follow the syntax outlined in the checkin policy
> *** eg: Resolves: RHEL-1234
> *** Commit c8abf80acd2192342ed1f14e867523a24f761797 denied
> *** Current checkin policy requires:
> ((release == + and internal_target_release == 10.0) or (((jiraProject ==
> RHEL)) and (jiraField(fixVersions) == rhel-10.0)))
> *** For additional help, please review the documentation at
> https://docs.engineering.redhat.com/pages/viewpage.action?spaceKey=EXDSPRHELB&title=Managing+dist-git+policy
> This change does not have the requisite ticket approvals. See above for details
> ```
>
> Have the rules about this requirement changed again? And if so, how exactly and
> why exactly?
>

No, it looks like there's a bug in check-tickets. Could you open a
ticket in the CS project for me, please?

I'm guessing I didn't adequately handle the special case of Beta/GA.

Thanks for reporting this.