XMLWordPrintable

Details

    Description

      Recent example of "new file, who dis?" problem is in the imagepuller sync, which is failing to trigger rhpkg container-build because:

      11:13:10 + log '[INFO] Commit new sources'
      11:13:10 + [[ 1 -gt 0 ]]
      11:13:10 + echo '[INFO] Commit new sources'
      11:13:10 [INFO] Commit new sources
      11:13:10 + rhpkg new-sources resources.tgz
      11:13:10 Uploading: resources.tgz
      11:13:13 Source upload succeeded. Don't forget to commit the sources file
      11:13:13 + git commit -s -m '[tgz] Update resources.tgz' sources
      11:13:13 [crw-2.7-rhel-8 cec79e5] [tgz] Update resources.tgz
      11:13:13  1 file changed, 1 insertion(+), 1 deletion(-)
      11:13:13 + git push
      11:13:16 remote: *** No rules for crw-2.7-rhel-8.  Happy hacking!        
      11:13:24 remote: * Publishing information for 1 commits        
      11:13:24 To ssh://pkgs.devel.redhat.com/containers/codeready-workspaces-imagepuller
      11:13:24    f581507..cec79e5  crw-2.7-rhel-8 -> crw-2.7-rhel-8
      11:13:24 + sudo rm -fr /tmp/tmp.kFyEJrzRtr /tmp/tmp.gkS1FaHd8h
      11:13:24 + git status
      11:13:24 On branch crw-2.7-rhel-8
      11:13:24 Your branch is up to date with 'origin/crw-2.7-rhel-8'.
      11:13:24 
      11:13:24 Changes to be committed:
      11:13:24   (use "git reset HEAD <file>..." to unstage)
      11:13:24 
      11:13:24 	new file:   .gitignore
      11:13:24 
      11:13:24 Untracked files:
      11:13:24   (use "git add <file>..." to include in what will be committed)
      11:13:24 
      11:13:24 	bootstrap.Dockerfile
      

      https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/CRW_CI/job/crw-sync-to-downstream_2.7/20/console

      and

      11:25:22 Could not execute container_build: /mnt/hudson_workspace/workspace/CRW_CI/get-sources-rhpkg-container-build_2.7/sources has uncommitted changes.  Use git status to see details
      

      https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/CRW_CI/job/get-sources-rhpkg-container-build_2.7/136/console

      So, when we're pushing the sources file, we should also make sure we've added and committed any other new/untracked files.

      This will likely impact other projects too, not just imagepuller.

      Attachments

        Issue Links

          Activity

            People

              nickboldt Nick Boldt
              nickboldt Nick Boldt
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: