Uploaded image for project: 'OpenShift Console'
  1. OpenShift Console
  2. CONSOLE-4610

[TOPOLOGY] Refactor createModalLauncher consumers to a hook form.

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • None
    • None
    • None
    • OCP Console - Sprint 276

      As part of the work on react-router v5 drop, we need to migrate from the createModalLauncher to the useOverlay hook instead.

      There are several createModalLauncher instances within TOPOLOGY plugin, these are listed in Inventory of createModalLauncher in Console. We should either refactor those to hook equivalent which would wrap and return the existing actions or move them under FC. Some prior refactors that have been done are a good reference point for what is expected - https://github.com/openshift/console/pull/13506https://github.com/openshift/console/pull/15078 or https://github.com/openshift/console/pull/15063
      AC:

      1. Refactor existing uses of createModalLauncher instances by migrating them to a hook pattern 
      2. Consolidate consumers of the new refactored hook form.
      3. Check the tests. Some of the refactored code could be used in tests.

              viraj-1 Vikram Raj
              rh-ee-mziska Marek Ziska (Inactive)
              None
              None
              Yanping Zhang Yanping Zhang
              None
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: