Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-55883

[Tracker] Remove programmatic skips from T2 Virt node lanes

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • CNV Virt-Node
    • None
    • 0.42
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • None

      Remove all programmatic skips from 

      tests/virt/node.

      Current skips:

      tests/virt/node/conftest.py:    if param.get("skip_migration"):
      tests/virt/node/conftest.py:def skip_windows_if_on_psi_cluster(is_psi_cluster, hotplugged_vm):
      tests/virt/node/descheduler/conftest.py:def skip_if_1tb_memory_or_more_node(allocatable_memory_per_node_scope_module):
      tests/virt/node/descheduler/test_descheduler.py:        "skip_if_1tb_memory_or_more_node",
      tests/virt/node/general/test_disk_io_option.py:pytestmark = pytest.mark.usefixtures("skip_test_if_no_ocs_sc")
      tests/virt/node/general/test_disk_io_option.py:@pytest.mark.usefixtures("skip_on_psi_cluster")
      tests/virt/node/general/test_machinetype.py:    skip_if_no_common_cpu,
      tests/virt/node/general/test_machinetype.py:    skip_access_mode_rwo_scope_function,
      tests/virt/node/general/test_machinetype.py:    skip_if_no_common_cpu,
      tests/virt/node/general/test_machinetype.py:    skip_access_mode_rwo_scope_function,
      tests/virt/node/general/test_networkinterfacemultiqueue_feature.py:@pytest.mark.usefixtures("skip_on_psi_cluster", "golden_image_data_volume_scope_class")
      tests/virt/node/general/test_oom.py:@pytest.mark.usefixtures("skip_on_psi_cluster")
      tests/virt/node/general/test_oom.py:    skip_if_workers_vms,
      tests/virt/node/general/test_windows_vtpm_bitlocker.py:    pytest.mark.usefixtures("skip_if_workers_vms"),
      tests/virt/node/general/test_windows_vtpm_bitlocker.py:        skip_if_no_common_modern_cpu,
      tests/virt/node/general/test_windows_vtpm_bitlocker.py:        skip_access_mode_rwo_scope_function,
      tests/virt/node/general/test_wsl2.py:pytestmark = pytest.mark.usefixtures("skip_on_psi_cluster")
      tests/virt/node/general/test_wsl2.py:        skip_if_no_common_modern_cpu,
      tests/virt/node/general/test_wsl2.py:        skip_access_mode_rwo_scope_function,
      tests/virt/node/gpu/conftest.py:def nodes_with_supported_gpus(skip_if_no_gpu_node, gpu_nodes, workers_utility_pods):
      tests/virt/node/gpu/conftest.py:def skip_if_only_one_gpu_node(nodes_with_supported_gpus):
      tests/virt/node/gpu/gpu_pci_passthrough/test_windows_vm_with_gpu_pci_passthrough.py:        "skip_on_psi_cluster",
      tests/virt/node/gpu/vgpu/test_rhel_vm_with_vgpu.py:    "skip_if_only_one_gpu_node",
      tests/virt/node/gpu/vgpu/test_windows_vm_with_vgpu.py:        "skip_on_psi_cluster",
      tests/virt/node/high_performance_vm/test_high_performance_templates.py:pytestmark = pytest.mark.usefixtures("skip_if_no_cpumanager_workers")
      tests/virt/node/high_performance_vm/test_high_performance_templates.py:@pytest.mark.usefixtures("skip_on_psi_cluster", "high_performance_vm", "cputune_is_in_dumpxml")
      tests/virt/node/high_performance_vm/test_iothreads_policy.py:pytestmark = pytest.mark.usefixtures("skip_if_no_cpumanager_workers")
      tests/virt/node/high_performance_vm/test_isolate_emulator_thread.py:pytestmark = pytest.mark.usefixtures("skip_if_no_cpumanager_workers")
      tests/virt/node/high_performance_vm/test_isolate_emulator_thread.py:        skip_if_no_common_cpu,
      tests/virt/node/high_performance_vm/test_isolate_emulator_thread.py:        skip_access_mode_rwo_scope_function,
      tests/virt/node/high_performance_vm/test_numa.py:        "skip_if_workers_vms",
      tests/virt/node/high_performance_vm/test_numa.py:        "skip_if_no_cpumanager_workers",
      tests/virt/node/high_performance_vm/test_numa.py:        "skip_if_numa_not_configured_or_enabled",
      tests/virt/node/high_performance_vm/test_numa.py:def skip_if_numa_not_configured_or_enabled(schedulable_nodes, workers_utility_pods):
      tests/virt/node/high_performance_vm/test_numa.py:    skip_when_no_sriov,
      tests/virt/node/hotplug/test_cpu_memory_hotplug.py:pytestmark = pytest.mark.usefixtures("skip_if_no_common_modern_cpu", "skip_access_mode_rwo_scope_module")
      tests/virt/node/hotplug/test_cpu_memory_hotplug.py:def skip_windows_memory_hotunplug_test(hotplugged_vm):
      tests/virt/node/hotplug/test_cpu_memory_hotplug.py:    def test_hotplug_cpu(self, skip_windows_if_on_psi_cluster, hotplugged_sockets_memory_guest, hotplugged_vm):
      tests/virt/node/hotplug/test_cpu_memory_hotplug.py:        [pytest.param({"sockets": FOUR_CPU_SOCKETS, "skip_migration": True})],
      tests/virt/node/hotplug/test_cpu_memory_hotplug.py:    def test_hotplug_memory(self, skip_windows_if_on_psi_cluster, hotplugged_sockets_memory_guest, hotplugged_vm):
      tests/virt/node/hotplug/test_cpu_memory_hotplug.py:        self, skip_windows_memory_hotunplug_test, hotplugged_sockets_memory_guest, hotplugged_vm
      tests/virt/node/hotplug/test_cpu_memory_hotplug.py:        [pytest.param({"memory_guest": FOUR_GI_MEMORY, "skip_migration": True})],
      tests/virt/node/hyperv_support/test_hyperv_features_in_vm.py:def skip_if_no_evmcs_support(schedulable_nodes):
      tests/virt/node/hyperv_support/test_hyperv_features_in_vm.py:@pytest.mark.usefixtures("skip_on_psi_cluster")
      tests/virt/node/hyperv_support/test_hyperv_features_in_vm.py:        skip_if_no_evmcs_support,
      tests/virt/node/hyperv_support/test_hyperv_features_in_vm.py:        skip_if_no_evmcs_support,
      tests/virt/node/log_verbosity/test_log_virt_launcher.py:        skip_if_no_common_cpu,
      tests/virt/node/log_verbosity/test_log_virt_launcher.py:        skip_access_mode_rwo_scope_function,
      tests/virt/node/migration_and_maintenance/test_dedicated_live_migration_network.py:@pytest.mark.usefixtures("skip_if_no_multinic_nodes")
      tests/virt/node/migration_and_maintenance/test_dedicated_live_migration_network.py:        skip_if_no_common_cpu,
      tests/virt/node/migration_and_maintenance/test_node_maintenance.py:    "skip_if_no_common_cpu",
      tests/virt/node/migration_and_maintenance/test_node_maintenance.py:    "skip_access_mode_rwo_scope_class",
      tests/virt/node/migration_and_maintenance/test_node_maintenance.py:    "skip_on_psi_cluster",
      tests/virt/node/migration_and_maintenance/test_node_maintenance.py:    "skip_if_no_common_modern_cpu",
      tests/virt/node/migration_and_maintenance/test_node_maintenance.py:    "skip_access_mode_rwo_scope_class",
      tests/virt/node/migration_and_maintenance/test_odf_vm_migration.py:    skip_if_no_common_cpu,
      tests/virt/node/migration_and_maintenance/test_odf_vm_migration.py:    skip_test_if_no_odf_cephfs_sc,
      tests/virt/node/migration_and_maintenance/test_post_copy_migration.py:    "skip_if_no_common_modern_cpu",
      tests/virt/node/migration_and_maintenance/test_post_copy_migration.py:    "skip_access_mode_rwo_scope_module",
      tests/virt/node/migration_and_maintenance/test_post_copy_migration.py:        self, skip_windows_if_on_psi_cluster, hotplugged_vm, vm_background_process_id, migrated_hotplugged_vm
      tests/virt/node/migration_and_maintenance/test_vm_disk_load_with_migration.py:    skip_if_no_common_cpu,
      tests/virt/node/migration_and_maintenance/test_vm_disk_load_with_migration.py:    skip_access_mode_rwo_scope_function,
      tests/virt/node/migration_and_maintenance/test_vm_memory_load_with_migration.py:pytestmark = pytest.mark.usefixtures("skip_if_no_common_modern_cpu", "skip_access_mode_rwo_scope_module")
      tests/virt/node/migration_and_maintenance/test_vm_memory_load_with_migration.py:    @pytest.mark.usefixtures("skip_on_psi_cluster")
      tests/virt/node/migration_and_maintenance/test_vm_memory_load_with_migration.py:        skip_if_workers_vms,
      tests/virt/node/migration_and_maintenance/test_vm_unscheduled_node.py:    skip_access_mode_rwo_scope_function,
      tests/virt/node/node_labeller/cpu_features/test_vm_with_cpu_features.py:    pytest.mark.usefixtures("skip_if_amd_cpu_nodes"),
      tests/virt/node/node_labeller/cpu_features/test_vm_with_cpu_features.py:def skip_if_amd_cpu_nodes(nodes_cpu_vendor):
      tests/virt/node/node_labeller/test_node_labeller_annotation.py:def worker1_skip_node_annotated(worker_node1):
      tests/virt/node/node_labeller/test_node_labeller_annotation.py:    @pytest.mark.dependency(name=f"{TESTS_CLASS_NAME}::test_node_labeller_added_skip_node_annotation")
      tests/virt/node/node_labeller/test_node_labeller_annotation.py:    def test_node_labeller_added_skip_node_annotation(self, worker1_skip_node_annotated, labelled_worker_node1):
      tests/virt/node/node_labeller/test_node_labeller_annotation.py:    @pytest.mark.dependency(depends=[f"{TESTS_CLASS_NAME}::test_node_labeller_added_skip_node_annotation"])
      tests/virt/node/node_labeller/test_node_labeller_annotation.py:    def test_node_labeller_removed_skip_node_annotation(self, labelled_worker_node1):
      tests/virt/node/readonly_disk/test_vm_with_windows_guest_tools.py:pytestmark = pytest.mark.usefixtures("skip_on_psi_cluster")
      tests/virt/node/readonly_disk/test_vm_with_windows_guest_tools.py:        skip_if_no_common_modern_cpu,
      tests/virt/node/readonly_disk/test_vm_with_windows_guest_tools.py:        skip_access_mode_rwo_scope_class,
      tests/virt/node/workload_density/test_free_page_reporting.py:def skip_if_no_hugepages_1gi(workers):
      tests/virt/node/workload_density/test_free_page_reporting.py:def test_free_page_reporting_in_vm_with_hugepages(skip_if_no_hugepages_1gi, vm_with_hugepages):
      tests/virt/node/workload_density/test_kernel_samepage_merging.py:        skip_if_no_common_cpu,
      tests/virt/node/workload_density/test_kernel_samepage_merging.py:        skip_access_mode_rwo_scope_function,
      tests/virt/node/workload_density/test_swap.py:    "skip_if_compact_cluster",
      tests/virt/node/workload_density/test_swap.py:    "skip_if_wasp_agent_disabled",
      tests/virt/node/workload_density/test_swap.py:def skip_if_wasp_agent_disabled(wasp_agent_daemonset):
      tests/virt/node/workload_density/test_swap.py:@pytest.mark.usefixtures("skip_if_workers_bms")
      tests/virt/node/workload_density/test_swap.py:        skip_if_no_common_cpu, 

       

      dshchedr@redhat.com we need to remove the programmatic skips from openshift-virtualization-tests. Except for the migration related skips, we can remove the other ones.

      In some cases you would need to create tasks for Devops. E.g. for tests that should not run against compact cluster, pipeline that runs that test, must allocate non-compact cluster. You can change the skip to fail also.

       

              sgott@redhat.com Stuart Gott
              rhn-support-dbasunag Debarati Basu-Nag
              Denys Shchedrivyi Denys Shchedrivyi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: