Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-44072

Virtctl ownership

XMLWordPrintable

    • cnv-virtctl-ownership
    • 77
    • Hide
      • All virtctl related e2e tests are located within tests/virtctl
      • virtctl is not used in e2e tests to test API endpoints (test them with the client instead)
      • Code in pkg/virtctl meets the criteria defined in the upstream coding conventions (best effort)
      • Code in pkg/virtctl is covered by unit tests as best as possible
      • Code in pkg/virtctl has no dependencies on tests/virtctl
      • Code in cmd/virtctl and tests/virtctl passes linters
      Show
      All virtctl related e2e tests are located within tests/virtctl virtctl is not used in e2e tests to test API endpoints (test them with the client instead) Code in pkg/virtctl meets the criteria defined in the upstream coding conventions (best effort) Code in pkg/virtctl is covered by unit tests as best as possible Code in pkg/virtctl has no dependencies on tests/virtctl Code in cmd/virtctl and tests/virtctl passes linters
    • Green
    • To Do
    • VIRTSTRAT-334 - 2024 Code Quality
    • VIRTSTRAT-3342024 Code Quality
    • 0% To Do, 0% In Progress, 100% Done
    • dev-ready, doc-ready, po-ready, qe-ready, ux-ready
    • Hide

      2025-01-06:
      some code changes will be not in cnv 4.18, but since this is a code clean-up, this does not matter....

      Show
      2025-01-06: some code changes will be not in cnv 4.18, but since this is a code clean-up, this does not matter....
    • No

      Goal

      The kubevirt/kubevirt code base would benefit from having owners of dedicated areas.

      User Stories

      • As a developer I want a clean code struct, so that it is a joy to add new feature and to fix bugs.
      • As a developer I want all functional tests to pass without flakes, so that the build would pass all gates, so that upstream CI is reliable passing and the downstream builds are delivered to stakeholders without delay.

      Non-Requirements

      • Functional or UX improvements are nice to have.

      Notes

      • Any additional details or decisions made/needed

            [CNV-44072] Virtctl ownership

            Dominik Holler added a comment -

            GREEN: some code changes will be not in cnv 4.18, but since this is a code clean-up, this does not matter.

            Dominik Holler added a comment - GREEN: some code changes will be not in cnv 4.18, but since this is a code clean-up, this does not matter.

            Felix Matouschek added a comment -

            GREEN: some code changes will be not in cnv 4.18, but since this is a code clean-up, this does not matter.

            Felix Matouschek added a comment - GREEN: some code changes will be not in cnv 4.18, but since this is a code clean-up, this does not matter.

            Felix Matouschek added a comment -

            GREEN: some code changes will be not in cnv 4.18, but since this is a code clean-up, this does not matter.

            Felix Matouschek added a comment - GREEN: some code changes will be not in cnv 4.18, but since this is a code clean-up, this does not matter.

            Dominik Holler added a comment -

            GREEN: some code changes will be not in cnv 4.18, but since this is a code clean-up, this does not matter.

            Dominik Holler added a comment - GREEN: some code changes will be not in cnv 4.18, but since this is a code clean-up, this does not matter.

            Dominik Holler added a comment -

            GREEN: some code changes might be not in cnv 4.18, but since this is a code clean-up, this does not matter.

            Dominik Holler added a comment - GREEN: some code changes might be not in cnv 4.18, but since this is a code clean-up, this does not matter.

            Felix Matouschek added a comment -

            There are no plans yet for virtctl's evolution, but the core of virtctl will stay in kubevirt/kubevirt. Functests should live under `tests/virtctl`, see https://issues.redhat.com/browse/CNV-45304.

            Felix Matouschek added a comment - There are no plans yet for virtctl's evolution, but the core of virtctl will stay in kubevirt/kubevirt. Functests should live under `tests/virtctl`, see https://issues.redhat.com/browse/CNV-45304 .

            Ben Oukhanov added a comment -

            vromanso@redhat.com fmatousc@redhat.com Did you mention a new effort to create a new external repository dedicated to have virtctl pkg and tests?

            Ben Oukhanov added a comment - vromanso@redhat.com fmatousc@redhat.com Did you mention a new effort to create a new external repository dedicated to have virtctl pkg and tests?

              fmatousc@redhat.com Felix Matouschek
              unassigned_jira Unassigned
              Geetika Kapoor Geetika Kapoor
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: