Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-38614

Compute: reduce usage of libdomain

XMLWordPrintable

    • no-lib-domain
    • Product / Portfolio Work
    • 77
      • No functional tests using the deprecated libdomain package
    • In Progress
    • VIRTSTRAT-334 - 2024 Code Quality
    • VIRTSTRAT-3342024 Code Quality
    • 38% To Do, 38% In Progress, 25% Done
    • dev-ready, doc-ready, po-ready, qe-ready, ux-ready

      Goal

      kubevirt compute e2e tests should not depend on libdomain.GetRunningVMIDomainSpec or libdomain.GetRunningVirtualMachineInstanceDomainXML unless absolutely necessary

      User Stories

      • As a KubeVirt developer, I want to find my end-to-end tests to test API behavior, not implementation details. Implementation details such as libvirt's domain XML/Spec should be tested in unit tests.

      Non-Requirements

      • List of things not included in this epic, to alleviate any doubt raised during the grooming process.

      Notes

      • Specifically,
        $ git grep libdomain
        .| wc -l
        68
        should be zero or next-to-zero.
      •  I believe that every usage of `GetRunningVMIDomainSpec` is a code smell, signifying one or more of:
        • an e2e test that should be converted to a unit test
        • an e2e test that does not cover the user story
        • a missing KubeVirt API

          1.
          upstream roadmap issue Sub-task Closed Normal Unassigned
          2.
          upstream design Sub-task Closed Normal Unassigned
          3.
          upstream documentation Sub-task Closed Normal Unassigned
          4.
          upgrade consideration Sub-task Closed Normal Unassigned
          5.
          CEE/PX summary presentation Sub-task Closed Normal Unassigned
          6.
          test plans in polarion Sub-task Closed Normal Unassigned
          7.
          automated tests Sub-task Closed Normal Unassigned
          8.
          downstream documentation merged Sub-task Closed Normal Unassigned

              sgott@redhat.com Stuart Gott
              dkenigsb@redhat.com Dan Kenigsberg
              Kedar Bidarkar Kedar Bidarkar
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated: