-
Epic
-
Resolution: Unresolved
-
Major
-
None
-
no-lib-domain
-
Product / Portfolio Work
-
77
-
- No functional tests using the deprecated libdomain package
-
In Progress
-
VIRTSTRAT-334 - 2024 Code Quality
-
-
38% To Do, 38% In Progress, 25% Done
-
dev-ready, doc-ready, po-ready, qe-ready, ux-ready
Goal
kubevirt compute e2e tests should not depend on libdomain.GetRunningVMIDomainSpec or libdomain.GetRunningVirtualMachineInstanceDomainXML unless absolutely necessary
User Stories
- As a KubeVirt developer, I want to find my end-to-end tests to test API behavior, not implementation details. Implementation details such as libvirt's domain XML/Spec should be tested in unit tests.
Non-Requirements
- List of things not included in this epic, to alleviate any doubt raised during the grooming process.
Notes
- Specifically,
$ git grep libdomain
.| wc -l
68
should be zero or next-to-zero. - I believe that every usage of `GetRunningVMIDomainSpec` is a code smell, signifying one or more of:
- an e2e test that should be converted to a unit test
- an e2e test that does not cover the user story
- a missing KubeVirt API
1.
|
upstream roadmap issue |
|
Closed | |
Unassigned |
2.
|
upstream design |
|
Closed | |
Unassigned |
3.
|
upstream documentation |
|
Closed | |
Unassigned |
4.
|
upgrade consideration |
|
Closed | |
Unassigned |
5.
|
CEE/PX summary presentation |
|
Closed | |
Unassigned |
6.
|
test plans in polarion |
|
Closed | |
Unassigned |
7.
|
automated tests |
|
Closed | |
Unassigned |
8.
|
downstream documentation merged |
|
Closed | |
Unassigned |