Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-31828

Improve virt-controller TSC related logs

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • CNV v4.16.0
    • None
    • CNV Virtualization
    • None
    • CNV Virtualization Sprint 249, CNV Virtualization Sprint 250, CNV Virtualization Sprint 251
    • Medium
    • None

      1. There is a typo here, "Frequency" and not "Freqency"
       
       

      % cat -n ./pkg/virt-controller/watch/topology/nodetopologyupdater.go 
...
    44			log.DefaultLogger().Infof("TSC Freqency node update status: %d updated, %d skipped, %d errors", stats.updated, stats.skipped, stats.error)
...

      2. Can we make this log line clearer? Maybe put the node name? It's hard to understand this log without looking at the code, original is just a variable name for the node object.

          79			log.DefaultLogger().Reason(err).Object(original).Error("Can't determine TSC frequency of the original")

              ralavi@redhat.com Ram Lavi
              rhn-support-gveitmic Germano Veit Michel
              Denys Shchedrivyi Denys Shchedrivyi
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: