Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-31828

Improve virt-controller TSC related logs

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • CNV v4.16.0
    • None
    • CNV Virtualization
    • None
    • CNV Virtualization Sprint 249, CNV Virtualization Sprint 250, CNV Virtualization Sprint 251
    • Moderate
    • None

      1. There is a typo here, "Frequency" and not "Freqency"
       
       

      % cat -n ./pkg/virt-controller/watch/topology/nodetopologyupdater.go 
...
    44			log.DefaultLogger().Infof("TSC Freqency node update status: %d updated, %d skipped, %d errors", stats.updated, stats.skipped, stats.error)
...

      2. Can we make this log line clearer? Maybe put the node name? It's hard to understand this log without looking at the code, original is just a variable name for the node object.

          79			log.DefaultLogger().Reason(err).Object(original).Error("Can't determine TSC frequency of the original")

            [CNV-31828] Improve virt-controller TSC related logs

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (Moderate: OpenShift Virtualization 4.16.0 Images security update), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHSA-2024:4455

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (Moderate: OpenShift Virtualization 4.16.0 Images security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2024:4455

            Denys Shchedrivyi added a comment -

            Verified on CNV-v4.16.0.rhel9-2692

             

            Denys Shchedrivyi added a comment - Verified on CNV-v4.16.0.rhel9-2692  

            GitLab CEE Bot added a comment -

            CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_upstream_540838a9c74f27792085395ddbdefb05:

            Updated US source to: b740331 Merge pull request #11575 from kubevirt-bot/bump-kubevirtci

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_ upstream _540838a9c74f27792085395ddbdefb05 : Updated US source to: b740331 Merge pull request #11575 from kubevirt-bot/bump-kubevirtci

            GitLab CEE Bot added a comment -

            CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_upstream_f76f998cb1e680b1093edc7c868c6439:

            Updated US source to: 6893cf9 Merge pull request #11752 from fossedihelm/fix-override-retrieved-vmi-in-wait-pkg

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_ upstream _f76f998cb1e680b1093edc7c868c6439 : Updated US source to: 6893cf9 Merge pull request #11752 from fossedihelm/fix-override-retrieved-vmi-in-wait-pkg

            GitLab CEE Bot added a comment -

            CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_upstream_aba41bd97fe60dc0afe72cc84449a3fa:

            Updated US source to: 0525318 Merge pull request #11685 from fossedihelm/custom-fake-client

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_ upstream _aba41bd97fe60dc0afe72cc84449a3fa : Updated US source to: 0525318 Merge pull request #11685 from fossedihelm/custom-fake-client

            GitLab CEE Bot added a comment -

            CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_upstream_069bb1298347e605f2a5a63363fb32bf:

            Updated US source to: a8f72dd Merge pull request #11673 from akalenyu/pkg-errors

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_ upstream _069bb1298347e605f2a5a63363fb32bf : Updated US source to: a8f72dd Merge pull request #11673 from akalenyu/pkg-errors

            GitLab CEE Bot added a comment -

            CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_upstream_5a08b7b58d5b2e93f5868367c55f6f80:

            Updated US source to: bd8c81a Merge pull request #11540 from vasiliy-ul/tests-utility-images

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_ upstream _5a08b7b58d5b2e93f5868367c55f6f80 : Updated US source to: bd8c81a Merge pull request #11540 from vasiliy-ul/tests-utility-images

            GitLab CEE Bot added a comment -

            CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_upstream_204a610205bdba49bdc09ec1fcd79fde:

            Updated US source to: eaab797 Merge pull request #11538 from machadovilaca/refactor-kubevirt_vmi_number_of_outdated

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_ upstream _204a610205bdba49bdc09ec1fcd79fde : Updated US source to: eaab797 Merge pull request #11538 from machadovilaca/refactor-kubevirt_vmi_number_of_outdated

            GitLab CEE Bot added a comment -

            CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_upstream_2f17d022f0c0f656486baef75762d755:

            Updated US source to: 9db1b13 Merge pull request #11664 from jean-edouard/flakyleader

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_ upstream _2f17d022f0c0f656486baef75762d755 : Updated US source to: 9db1b13 Merge pull request #11664 from jean-edouard/flakyleader

            GitLab CEE Bot added a comment -

            CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_upstream_276510cff1e07a02f6289e17afff7072:

            Updated US source to: 93a5fda Merge pull request #11635 from BarthV/patch-1

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in a merge request of cpaas-midstream / openshift-virtualization / kubevirt on branch cnv-4.99-rhel-9_ upstream _276510cff1e07a02f6289e17afff7072 : Updated US source to: 93a5fda Merge pull request #11635 from BarthV/patch-1

              ralavi@redhat.com Ram Lavi
              rhn-support-gveitmic Germano Veit Michel
              Denys Shchedrivyi Denys Shchedrivyi
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: