Uploaded image for project: 'OpenShift API Server'
  1. OpenShift API Server
  2. API-1486

k8s 1.25 followups

XMLWordPrintable

      These are the followups after landing  API-1420

      1. Fix hack/update-vendor.sh, currently the process requires several steps as described in https://github.com/openshift/kubernetes/commit/cfda1cf1165?w=1. Ideally, we should not need any of this to mimic upstream behavior. The biggest offender seems to be our ginkgo's carries.

      2. Fix make update, currently the process requires manual intervention in src/k8s.io/code-generator/go.mod as described in https://github.com/openshift/kubernetes/commit/a9ff8762aba?w=1. Ideally, we should not need any of this to mimic upstream behavior.

      3. Upstream https://github.com/openshift/kubernetes/commit/54f002ede5b?w=1 similarly how KS was done in https://github.com/kubernetes/kubernetes/pull/100305.

      4. Switch from github.com/hashicorp/golang-lru to k8s.io/utils/lru -
         https://github.com/openshift/apiserver-library-go/pull/92

      5. hack/verify-import-boss.sh complains with the following errors (one of many):

         errors in package "k8s.io/kubernetes/cmd/kubeadm/app/util/patches":
   the following imports did not match any allowed prefix:
     gopkg.in/yaml.v3

      temporary fix is https://github.com/openshift/kubernetes/commit/3af2f68c89a?w=1. But it looks like the problem comes from vendor/k8s.io/gengo/examples/import-boss/generators/import_restrict.go:415 which is responsible for returning imports per package. Happens only on o/k fork.

      6. These flags should be removed from our operators https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components#removed-klog-flags

      Flag --openshift-config has been deprecated, to be removed
Flag --enable-logs-handler has been deprecated, This flag will be removed in v1.19
Flag --kubelet-read-only-port has been deprecated, kubelet-read-only-port is deprecated and will be removed.

      Aug 25 12:21:56 ip-10-0-150-151 systemd[1]: Starting Kubernetes Kubelet...
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --container-runtime has been deprecated, will be removed in 1.27 as the only valid value is 'remote'
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --minimum-container-ttl-duration has been deprecated, Use --eviction-hard or --eviction-soft instead. Will be removed in a future version.
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --cloud-provider has been deprecated, will be removed in 1.25 or later, in favor of removing cloud provider code from Kubelet.
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --volume-plugin-dir has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more >
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --provider-id has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more inform>
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --register-with-taints has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for mo>
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --pod-infra-container-image has been deprecated, will be removed in 1.27. Image garbage collector will get sandbox image information from CRI.
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --system-reserved has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more in>
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: I0825 12:21:57.262546    1468 server.go:200] "--pod-infra-container-image will not be pruned by the image garbage collector in kubelet and should also be set in the remote runtime"
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --container-runtime has been deprecated, will be removed in 1.27 as the only valid value is 'remote'
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --minimum-container-ttl-duration has been deprecated, Use --eviction-hard or --eviction-soft instead. Will be removed in a future version.
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --cloud-provider has been deprecated, will be removed in 1.25 or later, in favor of removing cloud provider code from Kubelet.
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --volume-plugin-dir has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more >
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --provider-id has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more inform>
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --register-with-taints has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for mo>
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --pod-infra-container-image has been deprecated, will be removed in 1.27. Image garbage collector will get sandbox image information from CRI.
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: Flag --system-reserved has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more in>
Aug 25 12:21:57 ip-10-0-150-151 hyperkube[1468]: W0825 12:21:57.267864    1468 feature_gate.go:238] Setting GA feature gate CSIMigrationGCE=false. It will be removed in a future release.

      7. Find if exists a test which mounts a ConfigMap into a Pod and then performs modification to that ConfigMap which should be reflected in the Pod. See https://kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#understanding-configmaps-and-pods.

      8. Verify all the test skips in the o/k and origin repositories to prevent situations like https://github.com/openshift/kubernetes/pull/1339.

      9. Add a unit test verifying [Conformance] are not skipped.

      10. Revive https://github.com/openshift/kubernetes/pull/1094.

      11. With recent ginkgo changes (https://github.com/soltysh/ginkgo/commits/openshift-2.1.4-v3 and later) see what's possible to be upstreamed.

      12. Revisit https://github.com/openshift/kubernetes/pull/1109 (see https://github.com/openshift/os/pull/1004 too).

      13. Get rid of UPSTREAM: <carry>: don't fail integration due to too many goroutines. See https://github.com/kubernetes/kubernetes/issues/108483#issuecomment-1087297596

            maszulik1@redhat.com Maciej Szulik
            maszulik1@redhat.com Maciej Szulik
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: