Value Statement

As part of achieving the Epic goals:

• Update the hypershift add-on manager to create the acm-hypershift-addon-agent-metrics ServiceMonitor in the agent-addon namespace of a managed cluster rather than in the openshift-monitoring namespace.
• In order to handle upgrade correctly, update the hypershift add-on manager to look for and delete from the openshift-monitoring namespace the ServiceMointer that was created by a prior-release version of the code.

Definition of Done for Engineering Story Owner (Checklist)

• The service monitor is created in the addon agent install namespace.
• The existing service monitor in openshift-monitoring namespace is removed upon upgrade.
• The "openshift.io/cluster-monitoring: true" label is added to the addon agent install namespace.
• The hypershift addon metrics data are still collected and visible via OCP monitoring. 
• Disabling the "hypershift-local-hosting" component in MCE does not remove the addon agent install namespace.

Development Complete

• The code is complete.
• Functionality is working.
• Any required downstream Docker file changes are made.

Tests Automated

• [ ] Unit/function tests have been automated and incorporated into the
  build.
• [ ] 100% automated unit/function test coverage for new or changed APIs.

Secure Design

• [ ] Security has been assessed and incorporated into your threat model.

Multidisciplinary Teams Readiness

• [ ] Create an informative documentation issue using the [Customer
  Portal_doc_issue template](
  https://github.com/stolostron/backlog/issues/new?assignees=&labels=squad%3Adoc&template=doc_issue.md&title=),
  and ensure doc acceptance criteria is met. Link the development issue to
  the doc issue.
• [ ] Provide input to the QE team, and ensure QE acceptance criteria
  (established between story owner and QE focal) are met.

Support Readiness

• [ ] The must-gather script has been updated.