-
Epic
-
Resolution: Done
-
Major
-
ACM 2.9.0, ACM 2.8.0, ACM 2.7.0
-
Improve PrometheusRules creates for ACM Hub deploy on managed OpenShift
-
False
-
None
-
False
-
Green
-
Done
-
0% To Do, 0% In Progress, 100% Done
Epic Goal
Avoid the proliferation of PrometheusRules into openshift-monitoring namespace. Use a label in the user-defined ACM hub cluster namespace: the label `openshift.io/cluster-monitoring: "true"` will cause CMO to scrape a namespace
Why is this important?
SRE-P governs openshift-* namespaces and has explicit tooling to control what can/cannot be created in openshift-monitoring namespace
Scenarios
A monitoring expert can validate the label `openshift.io/cluster-monitoring: "true"` will cause CMO (platform prometheus) to scrape a namespace without needing to enable user-workload-monitoring.
A user can deploy ACM Hub on ROSA/OSD/ARO/ROIC successfully.
A user can deploy ACM Hub on managed OpenShift and have the same level of alerting/monitoring as an ACM Hub on self-managed OpenShift.
A user should not have to perform any additional/different steps during their ACM hub on OpenShift anywhere.
Acceptance Criteria
Ensure an ACM Hub can be deployed on managed OpenShift with the SRE managed-cluster-validating-webhooks running at full speed.
Dependencies (internal and external)
- managed-cluster-validating-webhooks: https://github.com/openshift/managed-cluster-validating-webhooks/
- Obs, GRC, Installer - any component that introduces prom rules
Previous Work (Optional):
Open questions:
- Migration of existing PrometheusRules from the openshift-monitoring namespace- need to ensure those are gone and not duplicative to the new label path.
Done Checklist
- CI - CI is running, tests are automated and merged.
- Release Enablement <link to Feature Enablement Presentation>
- DEV - Upstream code and tests merged: <link to meaningful PR or GitHub
Issue> - DEV - Upstream documentation merged: <link to meaningful PR or GitHub
Issue> - DEV - Downstream build attached to advisory: <link to errata>
- QE - Test plans in Polarion: <link or reference to Polarion>
- QE - Automated tests merged: <link or reference to automated tests>
- DOC - Downstream documentation merged: <link to meaningful PR>