Uploaded image for project: 'OpenShift Workloads'
  1. OpenShift Workloads
  2. WRKLDS-1713

Update openshift/oc to reflect current distributions/v3 package structure

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • None
    • None
    • None

      https://github.com/distribution/distribution has changed their package structure before releasing v3 stable API and openshift/oc needs to be updated. See the associated epic for more context.

      openshift/oc imports the following packages that need to be dropped/reworked:

      $ grep -Rn 'registry/client' . | grep -v vendor
      ./pkg/cli/image/append/append.go:20:    "github.com/distribution/distribution/v3/registry/client"
      ./pkg/cli/image/imagesource/dryrun.go:9:        registryclient "github.com/distribution/distribution/v3/registry/client"
      ./pkg/cli/image/imagesource/s3.go:26:   "github.com/distribution/distribution/v3/registry/client/auth"
      ./pkg/cli/image/imagesource/s3.go:27:   "github.com/distribution/distribution/v3/registry/client/transport"
      ./pkg/cli/image/manifest/dockercredentials/credential_store_factory.go:8:       "github.com/distribution/distribution/v3/registry/client/auth"
      ./pkg/cli/image/mirror/mappings.go:11:  "github.com/distribution/distribution/v3/registry/client/auth"
      ./pkg/cli/image/mirror/mirror.go:18:    "github.com/distribution/distribution/v3/registry/client"
      ./pkg/cli/registry/info/info.go:9:      "github.com/distribution/distribution/v3/registry/client/transport"
      
      $ grep -Rn 'library-go/pkg/image/registryclient' . | grep -v vendor
      ./pkg/cli/admin/verifyimagesignature/manifest.go:12:    "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/append/append.go:30:    "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/append/dryrun.go:13:    "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/extract/extract.go:29:  "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/imagesource/options.go:8:       "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/info/info.go:29:        "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/manifest/dockercredentials/credential_store_factory.go:10:      "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/manifest/dockercredentials/credential_store_factory_test.go:6:  "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/manifest/manifest.go:32:        "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/mirror/mirror.go:31:    "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/strategy/explicit.go:11:        "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/image/strategy/onerror.go:21: "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/registry/info/info.go:21:     "github.com/openshift/library-go/pkg/image/registryclient"
      ./pkg/cli/registry/login/login.go:29:   "github.com/openshift/library-go/pkg/image/registryclient"
      

      There are other issues present as well related simply to how distributions/v3 has changed, i.e. there is also no schema1 package, there is schema2, and reference package was split off into https://github.com/distribution/reference, which is compatible API-wise, though.

              rh-ee-okupka Ondřej Kupka
              rh-ee-okupka Ondřej Kupka
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: