XMLWordPrintable

Details

    • Story
    • Resolution: Done
    • Minor
    • 4.0.0.Beta4
    • None
    • None
    • None

    Description

      From Marc:

      • Rules having a long and non-title tilte name like "Replace class org.hibernate.jdbc.Batcher and its implementations" should be renamed to be able to relate it directly to the real issue more directly, for example using a common naming suffix "Hibernate 4", as in the rules in my PR. This means for example...
        "Replace class org.hibernate.jdbc.Batcher and its implementations" -> "Hibernate 4 Batcher replacement"
        "Replace class org.hibernate.jdbc.BatcherFactory and its implementations" -> "Hibernate 4 BatcherFactory replacement"
        "Replace class org.hibernate.engine.SessionImplementor" -> "Hibernate 4 SessionImplementor replacement"
        "The removed classes in org.hibernate.classic package " -> "Hibernate 4 Deprecated classes"
        I am sure that other rules like that should be reviewed.

      I think the naming suggested is not quite correct – they imply that we're replacing the Hibernate 4 version of something with a newer version, but these are rules are for moving TO Hibernate 4.

      I'd suggest wording like:
      BatcherFactory deprecated in Hibernate 4

      and for the last one about org.hibernate.classic:
      org.hibernate.classic removed in Hibernate 4

      If we do remove the FQCNs from the titles, this applies to the Hibernate 4->5 rules too.

      Attachments

        Activity

          People

            mnovotny@redhat.com Marek Novotny
            dansmit Dan Smith (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: