• Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 2.5.0.Final
    • 2.5.0.CR1
    • EAP6 -> EAP7
    • None

      The rule created for JBoss Web valves (WINDUPRULE-59) is insufficient. It provides a warning when a <valve> element is present in jboss-web.xml, but:

      1. It says that the migration effort is zero, which is clearly not true.
      2. It doesn't find valve classes. Those should be marked as well (for example, a valve present in the application that is for some reason not present in jboss-web.xml should still be considered when planning migration). It should be enough to find if the application contains any implementations of interface org.apache.catalina.Valve (I think Windup is able to do that, no? Typically, valves are created by subclassing org.apache.catalina.valves.ValveBase, but finding all implementors of the interface is more general).

              mbriskar_jira Matej Briskar (Inactive)
              lthon@redhat.com Ladislav Thon
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: