Uploaded image for project: 'WINDUP - Red Hat Application Migration Toolkit'
  1. WINDUP - Red Hat Application Migration Toolkit
  2. WINDUP-715

Misleading message from ScanPackagesOption

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 2.4.0.Final
    • 2.3.0.Final
    • None
    • None

    Description

      I ran windup with the argument "--packages com" and got the following warning message:

      WARNING: No packages were set in --packages. This will cause all .jar files to be decompiled and can possibly take a long time.

      This is quite misleading as using package com should at the very least filter out all org.* classes, a very broad filter to eliminate scanning of third party open source libraries. When I saw the warning, I thought that windup had a bug since I clearly set the packages argument to com. I looked at the source here:

      https://github.com/windup/windup/blob/master/rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/config/ScanPackagesOption.java

      and clearly on line 58, the conditional is checking if the option is missing OR if the option is too general (i.e. only a TLD and no second level qualifier). Either this should be split out into 2 checks or the message should be made more clear that TLD's are considered "too general" and describe the implications.

      Attachments

        Activity

          People

            jsightle@redhat.com Jess Sightler
            rhn-engineering-rruss Rodney Russ
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: