-
Bug
-
Resolution: Done
-
Major
-
2.0.0.Alpha1
-
None
The following methods are inconsistent, see comments.
Better the producer should call initialize(), which would set graphContext if null to what's returned by create(). setGraphDirectory() should not be called in this class, or handled through a config object.
// Sets this.graphContext @Override public GraphContext create() { return produceGraphContext(); } // Does not touch nor inspect this.graphContext @Override public GraphContext create(Path runDirectory) { GraphContextImpl context = new GraphContextImpl(graphServices, this.graphTypeRegistry, this.graphApiCompositeClassLoaderProvider); context.setGraphDirectory(runDirectory); return context; } // Sets this.graphContext @Produces @ApplicationScoped public GraphContext produceGraphContext() { if (this.graphContext == null) { this.graphContext = new GraphContextImpl(graphServices, this.graphTypeRegistry, this.graphApiCompositeClassLoaderProvider); } return graphContext; }
- blocks
-
WINDUP-253 Refactor WindupProcessor/Impl
- Closed