Uploaded image for project: 'OpenShift Windows Containers'
  1. OpenShift Windows Containers
  2. WINC-926

Fix how kubelet handles OS specific configuration

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • 3
    • None
    • None
    • WINC - Sprint 270

      Description

      Kubelet handles OS specific configuration options, specifically EnforceNodeAllocatable, in a manner that makes creating kublet configuration for Windows difficult. Currently EnforceNodeAllocatable's value must be explicitly set to the empty array [] to avoid error. Instead, kubelet should respect [none] as a value.
       

      Engineering Details

       
      We currently have to append the option with the proper empty value instead of including in the kubelet configuration object. Otherwise, when marshalling, the empty value will be omitted entirely from the config file. The default value is [pods], so if this option is not present in the config it would end up being incorrectly populated at service start time.

      Acceptance Criteria

      • Kubelet does not error out when EnforceNodeAllocatable: [none] is provided as an option.
      • In WMCO, we can specify EnforceNodeAllocatable in the kubelet configuration struct

       

      QE notes: see https://issues.redhat.com/browse/WINC-926?focusedId=27098749&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27098749

              jvaldes@redhat.com Jose Valdes
              mohashai Mohammad Shaikh (Inactive)
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: