-
Story
-
Resolution: Won't Do
-
Minor
-
None
-
None
-
None
-
2
-
False
-
None
-
False
User or Developer story
As a Cluster Admin, I want the `windows-user-data` secret to entertaining the <presist> tag only for the required platform, i.e. AWS, so that the content of the userData is cleaner and relevant to the target platform.
Description
This ticket can be seen as a follow-up to https://issues.redhat.com/browse/WINC-888. WINC-888 defaults both tags (<powershell> and <persist>) for all platform where the <persist> tag is only required for AWS. See: https://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/ec2-windows-user-data.html#user-data-batch-scripts
For Azure the user data is persistent and will be available during the lifetime of the VM. See https://learn.microsoft.com/en-us/azure/virtual-machines/user-data#what-is-user-data.
Engineering Details
Update the logic in https://github.com/openshift/windows-machine-config-operator/blob/master/pkg/secrets/secrets.go#L40 to only apply the `<persist>true</persist>` tag when the platform type is AWS
For QE:
only regression testing needed
Acceptance Criteria
- UserData for AWS contains the <persist>true</persist> tag
- Default userData contains only the <powershell> tag enclosing the content.