-
Story
-
Resolution: Done
-
Normal
-
None
-
None
-
Improvement
-
5
-
False
-
False
-
Undefined
-
WINC - Sprint 261, WINC - Sprint 262
STORY:
As a WMCO developer, I want components that do not make changes to Machine object like metrics configuration to be handled by a separate controller.
DESCRIPTION:
Currently windowsmachine controller is responsible for handling external configuration like Prometheus, even when it does not modify a Windows Machine object. WMCO checks for metrics being enabled on the namespace its deployed only in at startup. WMCO ignores the change if metrics are enabled/disabled while WMCO is running. This should be handled by an independent controller like node controller that checks for the state of Prometheus configuration for any changes.
There is an endpoint named kubelet in the kube-system namespace which contains all the node IP addresses. WMCO can rely on this endpoint and create the serviceMonitor to scrape this endpoint instead of creating a new one.
ACCEPTANCE CRITERIA:
- Node controller is extended to handle metrics configuration.
- All existing e2e should continue to pass.
- links to
-
RHBA-2024:137899 Red Hat OpenShift for Windows Containers 10.18.0 product release
- mentioned on