-
Task
-
Resolution: Done
-
Major
-
None
-
None
-
None
-
Quality / Stability / Reliability
-
False
-
-
False
-
None
-
None
-
None
-
None
-
None
Add "Byoh-" test label to identify BYOH-specific Windows Containers tests
Background
Currently, BYOH (Bring Your Own Host) Windows Containers tests run on all platforms, but there's no way to selectively run only BYOH tests. Similar to the "Smokerun-" label, we need a "Byoh-" label to:
- Identify tests that specifically test BYOH functionality
- Allow filtering to run only BYOH tests on Phase 1 platforms (AWS UPI, Nutanix UPI)
- Prevent BYOH tests from running on IPI platforms where BYOH is not supported
What This Story Delivers
Pipeline Label Registration
Add "Byoh-" to the framework labels list in pipeline/handleresult.py (similar to "Smokerun-", "Longduration-", etc.)
Test Name Updates
Update 5 BYOH test names in test/extended/winc/winc.go to include "Byoh-" prefix:
- OCP-42496 - Configure Windows instance with DNS
- OCP-42484 - Configure Windows instance with IP
- OCP-42516 - Configure Windows instance with IP and DNS
- OCP-44099 - Secure Windows workers username annotation
- OCP-82694 - Verify containerd path removal
CI Job Filter Updates (Future Work)
Update TEST_FILTERS in Phase 1 platform CI jobs to include Byoh& filter:
- AWS UPI jobs (added in WINC-1652)
- Nutanix UPI jobs
Files Changed
openshift-tests-private Repository
- pipeline/handleresult.py - Add "Byoh-" to frameworkLabels list
- test/extended/winc/winc.go - Add "Byoh-" prefix to 5 test names
- test/extended/winc/README.md - Document Byoh label usage
Technical Details
Example Label Registration
# pipeline/handleresult.py (line ~36) frameworkLabels = [ "Smokerun-", "Byoh-", # NEW "Longduration-", "NonPreRelease-", # ... ]
Example Test Name Update
// Before It("OCP-42496-Author:xxia-High-ConnectedOnly-Configure a Windows instance with DNS", func() { setBYOH() // test implementation }) // After It("Byoh-OCP-42496-Author:xxia-High-ConnectedOnly-Configure a Windows instance with DNS", func() { setBYOH() // test implementation })
Example CI Job Filter Update (Future)
# Example: aws-upi-ovn-winc-f7 job env: TEST_FILTERS: ~ChkUpgrade&;~ConnectedOnly&;Smokerun&;Byoh& TEST_SCENARIOS: Windows_Containers
Implementation Steps
1. Add "Byoh-" to frameworkLabels in pipeline/handleresult.py
2. Update 5 test names in test/extended/winc/winc.go with "Byoh-" prefix
3. Update test/extended/winc/README.md with documentation about Byoh label
4. Run make update and make test to verify changes
5. Create PR in openshift-tests-private repository
6. (Future) Update TEST_FILTERS in Phase 1 platform CI jobs to include Byoh&
Acceptance Criteria
- "Byoh-" added to frameworkLabels list in pipeline/handleresult.py
- All 5 BYOH tests prefixed with "Byoh-" in test/extended/winc/winc.go
- test/extended/winc/README.md documents the Byoh label
- Tests can be filtered using TEST_FILTERS with Byoh&
- All unit tests pass
- PR merged successfully
Related Work
- Epic: WINC-1473 (BYOH in Prow)
- Related Story: WINC-1508
- Task: WINC-1652 (AWS UPI CI jobs - will use Byoh& filter)
- PR: openshift/release#73920 (Phase 1 BYOH provisioning - MERGED)
Notes
- This label follows the same pattern as existing framework labels ("Smokerun-", "Longduration-", etc.)
- The label is part of the test name, not a Ginkgo v2 Label decorator
- All 5 tests already use setBYOH() function, making them easy to identify
- Future work: Update CI job TEST_FILTERS when BYOH is available on additional platforms