-
Task
-
Resolution: Unresolved
-
Normal
-
None
-
None
-
None
-
Quality / Stability / Reliability
-
False
-
-
False
-
None
-
None
-
None
-
None
-
None
Background
Original work from Jan 2024 (OCPQE-19088) to automate Polarion test case OCP-71173. PR #15762 was created in April 2024 but closed due to staleness without being merged.
Related Issues:
- OCPQE-19088: Test proxy connectivity with and without NoProxy
OCPBUGS-24264: Unable to add windows node to OCP 4.14 cluster with proxy enabled (Closed - Done)- Polarion: OCP-71173
- PR: https://github.com/openshift/openshift-tests-private/pull/15762
- Branch: ocp_71173 (commit 495bb4ea4)
Test Objective
Verify that Windows nodes correctly handle proxy configuration including:
- NO_PROXY environment variable is properly formatted (comma-separated)
- Dynamic proxy configuration changes trigger WMCO reboot
- Updated NO_PROXY values propagate to Windows nodes
- HTTP/HTTPS traffic works through proxy
- Load balancer traffic works (bypasses proxy via NO_PROXY)
Issues Found in Existing Code
Critical Issues:
- Undefined variable (line ~17): Uses noProxy instead of noProxyEnv
updatedNoProxy := noProxy + "," + newNoProxy // noProxy is undefined
- Duplicate nested loop (lines ~38-50): Same for loop is nested inside itself - copy-paste error
for _, host := range windowsHosts { // ... code ... for _, host := range windowsHosts { // DUPLICATE! // ... same code again ... } }
- Missing helper function: extractStatusCode referenced in testTraffic but not defined in the PR
- Hard-coded node count: Assumes exactly 2 Windows nodes
waitWindowsNodesReady(oc, 2, 6*time.Minute)
Test Failures:
- CI failures in debug-winc-gcp-ipi and debug-winc-aws-ipi
- PR needs rebase on current master
Work Required
- Fix code issues:
- Fix undefined variable reference
- Remove duplicate nested loop
- Implement or import extractStatusCode function
- Make node count dynamic using len(windowsHosts)
- Rebase and update:
- Rebase branch on current master
- Update test to follow current framework patterns
- Add proper error messages and logging
- Testing:
- Test on AWS IPI with proxy
- Test on GCP IPI with proxy
- Verify on different OCP versions
- Documentation:
- Update Polarion test case status
- Link automation to test case
Acceptance Criteria
- [ ] Code issues fixed
- [ ] PR passes CI on AWS and GCP
- [ ] Test validates all proxy scenarios
- [ ] Test is merged to master
- [ ] Polarion OCP-71173 marked as automated