Uploaded image for project: 'OpenShift Windows Containers'
  1. OpenShift Windows Containers
  2. WINC-1375

Remove kube-proxy submodule

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • 2
    • None
    • None
    • WINC - Sprint 267

      Description

      We currently have two submodules tracking openshift/kubernetes, kubelet and kube-proxy. The reasoning for having a separate submodule for kube-proxy was to handle the case in which kube-proxy specific bug/cve fixes were denied cherry-picking to the o/k release branch we were using. Originally kube-proxy submodule would track a separate branch of o/k specifically for kube-proxy such as `sdn-4.17-kubernetes-1.30.5`

      This has since been changed, where now the WMCO kube-proxy submodule tracks a tag in o/k, which points to a certain commit in the release-4.y branch. This doesn't solve the denied cherry-pick issue, as the tag would need to point to a branch that contains the fix.

      This ticket covers the removal of the second kube-proxy submodule as it is trying to solve a potential issue with a solution that causes numerous downsides.

      Benefits of removing the submodule:

      • reduced codebase size
      • reduced clone/build times
      • less CVE noise, as CVEs won't be duplicated across kubelet and kube-proxy submodules

      If a kube-proxy specific fix is needed for a release branch, and the fix does not make it into the matching kubelet release branch, the kube-proxy submodule can be re-added specifically for that release branch. This submodule would point to a branch in o/k specifically created to pick up this fix.

       

      Acceptance Criteria

      • kube-proxy submodule is removed, and kube-proxy.exe is built from the kubelet submodule
      • No change in WMCO functionality

              rh-ee-ssoto Sebastian Soto
              rh-ee-ssoto Sebastian Soto
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: