User or Developer story

As a WMCO developer, I want WICD cleanup to use the services ConfigMap tied to a node's Version annotation so that upgrades never leave behind OpenShift managed Windows services.

Description

We should use the version annotation instead of the desired version as the source of truth when deconfiguring Windows services. This makes it so we cleanup using the same ConfigMap version that was used to configure the instance, which is important to ensure there are no services left behind when upgrading e.g. if there is a change to the services CM spec between WMCO versions.

Engineering Details

The version annotation is not guaranteed to be present on a node when we invoke WICD cleanup (e.g. failure to start services leads to a reconcile before the version anno is applied). We should not error in such a case – instead read the desiredVersion annotation as backup if the version anno is not found on the node object.

Acceptance Criteria

During an upgrade of WMCO major versions from version A to version B:

• The services ConfigMap used as the source of truth for deconfiguration is the one associated with version A by default

Testing

QE: This will require a full upgrade test, upgrading cluster OCP version and WMCO major version. Please test

• upgrade from 8.0.0 to 9.0.0 when this merges into master
• from 7.1.0 to 8.y.z when the backport lands in release-4.13
• from 6.0.0 to 7.y.z when the backport lands in release-4.12