Uploaded image for project: 'WildFly Transaction Client'
  1. WildFly Transaction Client
  2. WFTC-82

XAResourceRegistry record cleanup cannot be permitted for XAResource.recover(TMENDRSCAN)

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Blocker
    • 1.1.11.Final
    • 1.1.10.Final
    • None

    Description

      This is effective revert of the fix provided in issue WFTC-77.

      The WFTC-77 tried to enhance integration with Narayana in way to permit deletion of the XAResourceRegistry record (https://github.com/wildfly/wildfly-transaction-client/blob/1.1.10.Final/src/main/java/org/wildfly/transaction/client/XAResourceRegistry.java) in case of call XAResource.recover(XAResource.TMENDRSCAN) (https://github.com/wildfly/wildfly-transaction-client/pull/99/files).

      The fix was not well considered.
      The ClientChannel (https://github.com/wildfly/wildfly-transaction-client/blob/1.1.10.Final/src/main/java/org/wildfly/transaction/client/provider/remoting/TransactionClientChannel.java#L437) works only with the XAResource.TMSTARTRSCAN flag and otherwise it returns empty array which leads to situation that XAResourceRegistry record is deleted when the remote side still contains some participants for recovery.

      My understanding is that intent of using only XAResource.TMSTARTRSCAN to proceed with the remote call and trying to find unfinished participants is the Narayana integration.
      Narayana finishes with the XAResource.recover(XAResource.TMENDRSCAN) call processing the XAResource in particular recovery cycle. It's uses only as a marker there is no other processing to be done. Narayana use no result of such call
      https://github.com/jbosstm/narayana/blob/5.10.4.Final/ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/recovery/arjunacore/XARecoveryModule.java#L831

      Attachments

        Issue Links

          is incorporated by

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-19408 [QE](7.3.z) Unfinished transactions in JMS crash recovery scenario using JTA

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Verified
          is related to

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-19435 (7.3.z) WFTC registry records may not be removed during the OpenShift scale down processing when transaction recovery commits

          • Critical - To be worked on immediately following BLOCKER issues.
          • Verified

          Bug - A problem that impairs or prevents the functions of the product. WFTC-85 XAResourceRegistry record needs to be clean immediatelly after commit is called even during recovery

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. JBEAP-19456 Upgrade wildfly-transaction-client to 1.1.11.Final

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Closed

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. WFLY-13437 Upgrade wildfly-transaction-client to 1.1.11.Final

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Closed

          Activity

            People

              ochaloup@redhat.com Ondrej Chaloupka (Inactive)
              ochaloup@redhat.com Ondrej Chaloupka (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: