Uploaded image for project: 'WildFly Maven Plugin'
  1. WildFly Maven Plugin
  2. WFMP-44

be able to indicate if I want to enable or disable deployment at deploy time

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 1.1.0.Alpha10
    • None
    • Core
    • None

      Sorry, I missed this when I originally reviewed the changes to introduce the new core API.

      The new maven-plugin-core API is missing the ability to say if I want the deployment to be initially disabled or enabled at deploy time.

      For example, I see in DeploymentOperations.addDeployOperationStep:

      op.get(ENABLE).set(true);

      Just look at all the places where the ENABLE(D) flags are set in all the operations. These should be configurable.

      For example, my temporary code has this (this is code that is going to be deleted because I'm just going to call the maven-plugin-core API, but it is missing something like this):

      https://github.com/hawkular/hawkular-agent/blob/master/hawkular-dmr-client/src/main/java/org/hawkular/dmrclient/deployment/Deployment.java#L207-L210

      So I should be able to do something like:

      Deployment deployment = Deployment.of(content, deploymentName)
      .addServerGroups(serverGroups)
      .setEnabled(false); // support this setter

      Now when I call forceDeploy, or deploy, or whatever, it will either be enabled or disabled depending on that setting. The default should obviously be "true" if not specified.

              jperkins-rhn James Perkins
              jmazzitelli John Mazzitelli
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: