Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-7913

Rename default-realm attribute in Elytron properties-realm

    Details

    • Steps to Reproduce:
      Hide

      Look into standalone.xml and search for "properties-realm":

      <properties-realm name="ApplicationRealm" default-realm="ApplicationRealm">
          <users-properties path="application-users.properties" relative-to="jboss.server.config.dir"/>
          <groups-properties path="application-roles.properties" relative-to="jboss.server.config.dir"/>
      </properties-realm>
      
      Show
      Look into standalone.xml and search for "properties-realm": <properties-realm name= "ApplicationRealm" default-realm= "ApplicationRealm" > <users-properties path= "application-users.properties" relative-to= "jboss.server.config.dir" /> <groups-properties path= "application-roles.properties" relative-to= "jboss.server.config.dir" /> </properties-realm>

      Description

      The newly introduced attribute default-realm in properties-realm configuration in Elytron is ambiguous and should be renamed. The attribute contains default value for realm-name and it's used in password hash computation. So it's rather related to users-properties part only.

      Suggestion for improvement:
      Rename the attribute to sth. like realm-name-to-hash and put it into users-properties configuration if possible.

      <properties-realm name="ApplicationRealm">
          <users-properties path="application-users.properties" relative-to="jboss.server.config.dir"  realm-name-to-hash="ApplicationRealm"/>
          <groups-properties path="application-roles.properties" relative-to="jboss.server.config.dir"/>
      </properties-realm>
      

      or (if it's not easy to have it in users-properties configuration)

      <properties-realm name="ApplicationRealm" realm-name-to-hash="ApplicationRealm">
          <users-properties path="application-users.properties" relative-to="jboss.server.config.dir"/>
          <groups-properties path="application-roles.properties" relative-to="jboss.server.config.dir"/>
      </properties-realm>
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  dlofthouse Darran Lofthouse
                  Reporter:
                  jcacek Josef Cacek
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: