Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-4878

ORB subsystem wrongly compare ModelNode property

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 10.0.0.Alpha5
    • None
    • IIOP
    • None

      It seems that wrong type comparision is used in TransformUtils class [1] when model node attribute is verified if(!value.equals("off")) ...

      When looking at ModelNode code of equal method [2] it seems that the comparistion will be false in any case.

      Found out during static code analyzis check.

      [1] https://github.com/wildfly/wildfly/blob/master/legacy/jacorb/src/main/java/org/jboss/as/jacorb/TransformUtils.java#L84
      [2] https://github.com/jbossas/jboss-dmr/blob/master/src/main/java/org/jboss/dmr/ModelNode.java#L1575

              tadamski@redhat.com Tomasz Adamski
              ochaloup@redhat.com Ondrej Chaloupka (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: