Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-4850

ManagementClient.isServerInRunningState fails when server is stopped

    XMLWordPrintable

    Details

      Description

      Scenario: server is stopped (killed), working with arquillian to check if server is started or not

      Current implementation of the ManagementClient.isServerInRunningState catches only IOException (see [1]) and in such case false is returned. Otherwise exception is propagated upwards.

      That's a problem in case that assertions are enabled - which is true statement for wildfly testsuite (see pom.xml, surefire configuration and <enableAssertions>true</enableAssertions>). As state of the server is checked with assertions as well [2] then test fails on such assertion instead of getting false as server is stopped.

      In comparision with arquillian client for jboss-eap there is caught Throwable and returned false [3] which seems to me more correct.

      Could you, please, forwardport arquillian client behaviour from JBoss EAP to WildFly?

      [1] https://github.com/wildfly/wildfly-arquillian/blob/master/common/src/main/java/org/jboss/as/arquillian/container/ManagementClient.java#L197
      [2] https://github.com/wildfly/wildfly-core/blob/master/protocol/src/main/java/org/jboss/as/protocol/mgmt/ActiveOperationSupport.java#L151
      [3] https://github.com/jbossas/jboss-eap/blob/6.x/arquillian/common/src/main/java/org/jboss/as/arquillian/container/ManagementClient.java#L177

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jperkins-rhn James Perkins
              Reporter:
              ochaloup@redhat.com Ondrej Chaloupka
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: