Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-20773

Large batch repositories can create OutOfMemoryError's when reading the management model

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Major Major
    • None
    • None
    • Batch
    • None
    • Hide

      Create a large repository or a larger repository on a server with limited memory. Then run the following CLI command on the deployment used to create the jobs in the repository:

      /deployment=*/:read-resource(recursive=true, include-runtime=true)
      Show
      Create a large repository or a larger repository on a server with limited memory. Then run the following CLI command on the deployment used to create the jobs in the repository: /deployment=*/:read-resource(recursive= true , include-runtime= true )
    • Hide

      Purge the number of jobs in the repository

      Show
      Purge the number of jobs in the repository
    • ---
    • ---

      The batch-jberet subsystem adds resources to a deployment for each job defined in a job XML file descriptor. If there are many descriptors or descriptors have a large quantity of job executions associated with them, reading the resource through a management operation may result in an OutOfMemoryError.

      The issue is caused by the org.wildfly.extension.batch.jberet.deployment.BatchJobExecutionResource which is registers each job execution for a given job. This method is the issue:

      /**
 * Note the access to the {@link #children} is <strong>not</strong> guarded here and needs to be externally
 * guarded.
 */
private void refreshChildren() {
    if (System.currentTimeMillis() - lastRefreshedTime < refreshMinInterval) {
        return;
    }

    final List<Long> executionIds = jobOperator.getJobExecutionsByJob(jobName);
    final Set<String> asNames = executionIds.stream().map(Object::toString).collect(Collectors.toSet());
    children.clear();
    children.addAll(asNames);
    lastRefreshedTime = System.currentTimeMillis();
}

      There is an attempt made not to refresh too fast introduced in WFLY-14275. However, this can still cause issues with very large repositories.

      A possible solution is to limit the number of jobs returned by the resource.

              bstansbe@redhat.com Brian Stansberry
              jperkins-rhn James Perkins
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: