Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-18844

Invalid XmlMerge output on Windows

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 31.0.0.Beta1, 31.0.0.Final
    • None
    • None
    • None

      The xml-merge task used by the docs.licenses.merge Galleon package generates incorrect output for the 'source' elements on Windows.

      https://github.com/wildfly/galleon-plugins/blob/main/galleon-plugins/src/main/java/org/wildfly/galleon/plugin/config/XmlMerge.java#L99 converts paths to URIs, which results in '/' being used as the separator char.

      But then https://github.com/wildfly/galleon-plugins/blob/main/galleon-plugins/src/main/java/org/wildfly/galleon/plugin/config/XmlMerge.java#L120 passes the host filesystem separator char.

      The merger.xsl in WildFly can fix this by ignoring the fileSeparator param and just using '/'. XmlMerge itself needs to keep passing the param as older versions of merger.xsl will expect it.

            bstansbe@redhat.com Brian Stansberry
            bstansbe@redhat.com Brian Stansberry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: